On Tue, 05 Apr 2016 22:22:03 -0700 Jean-Philippe ANDRÉ <[email protected]> said:

you know data was obj passed into _efl_vpath_manager_register(0 and obj there
is EFL_VPATH_MANAGER_CLASS because register is a class func :)

> jpeg pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=7eaf7af1d173921f20c4903a2d656554b9ec67fc
> 
> commit 7eaf7af1d173921f20c4903a2d656554b9ec67fc
> Author: Jean-Philippe Andre <[email protected]>
> Date:   Wed Apr 6 13:27:09 2016 +0900
> 
>     Efl vpath: Fix usage of @class function
>     
>     Calling an @class function with a real object is not safe.
>     Missing check somewhere? I believe this should have failed safely.
> ---
>  src/lib/efl/interfaces/efl_vpath_manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/efl/interfaces/efl_vpath_manager.c
> b/src/lib/efl/interfaces/efl_vpath_manager.c index fdf5e9a..59be446 100644
> --- a/src/lib/efl/interfaces/efl_vpath_manager.c
> +++ b/src/lib/efl/interfaces/efl_vpath_manager.c
> @@ -53,7 +53,7 @@ _register_sort_cb(Efl_Vpath_Manager_Entry *e1,
> Efl_Vpath_Manager_Entry *e2) static Eina_Bool
>  _cb_vpath_del(void *data, const Eo_Event *event)
>  {
> -   efl_vpath_manager_unregister(data, event->obj);
> +   efl_vpath_manager_unregister(EFL_VPATH_MANAGER_CLASS, event->obj);
>     eo_event_callback_del(event->obj, EO_BASE_EVENT_DEL, _cb_vpath_del, data);
>     return EINA_TRUE;
>  }
> 
> -- 
> 
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    [email protected]


------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to