On Apr 10, 2016 05:23, "Daniel Zaoui" <daniel.za...@samsung.com> wrote:
>
> jackdanielz pushed a commit to branch master.
>
>
http://git.enlightenment.org/core/efl.git/commit/?id=9936b92ce3305339756f42333eb19a580a585e1a
>
> commit 9936b92ce3305339756f42333eb19a580a585e1a
> Author: Daniel Zaoui <daniel.za...@samsung.com>
> Date: Sun Apr 10 14:55:05 2016 +0300
>
> CtxPopup: fix auto-hide property setting
>
> Set and get functions are inconsistent one with the other. When set
> function is used with a certain value, one expects the get function
> to return this value.
> ---
> src/lib/elementary/elc_ctxpopup.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/lib/elementary/elc_ctxpopup.c
b/src/lib/elementary/elc_ctxpopup.c
> index 89bbefa..0faeec6 100644
> --- a/src/lib/elementary/elc_ctxpopup.c
> +++ b/src/lib/elementary/elc_ctxpopup.c
> @@ -1330,7 +1330,6 @@ _elm_ctxpopup_dismiss(Eo *obj, Elm_Ctxpopup_Data
*sd)
> EOLIAN static void
> _elm_ctxpopup_auto_hide_disabled_set(Eo *obj EINA_UNUSED,
Elm_Ctxpopup_Data *sd, Eina_Bool disabled)
> {
> - disabled = !!disabled;
You should keep this line. It force the storage as a Boolean without
altering weird behavior. It'd good behavior on input checking.
> if (sd->auto_hide == !disabled) return;
> sd->auto_hide = !disabled;
> }
> @@ -1338,7 +1337,7 @@ _elm_ctxpopup_auto_hide_disabled_set(Eo *obj
EINA_UNUSED, Elm_Ctxpopup_Data *sd,
> EOLIAN static Eina_Bool
> _elm_ctxpopup_auto_hide_disabled_get(Eo *obj EINA_UNUSED,
Elm_Ctxpopup_Data *sd)
> {
> - return sd->auto_hide;
> + return !sd->auto_hide;
> }
>
> EOLIAN static void
>
> --
>
>
>
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/
gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
