On 19/04/16 13:04, Carsten Haitzler wrote: > On Tue, 19 Apr 2016 10:09:22 +0100 Tom Hacohen <t...@osg.samsung.com> said: > >> The commit message is a bit misleading. You didn't clean up the >> formatting, you made it horrible. > > all the vars are aligned at the same column... i think its far nicer to read > :)
I could agree that it maybe is more aesthetically pleasing, but the pain of maintaining those kind of things is just unbearable. :( > >> -- >> Tom >> >> On 19/04/16 09:40, Carsten Haitzler wrote: >>> raster pushed a commit to branch master. >>> >>> http://git.enlightenment.org/core/efl.git/commit/?id=1b266ff1e45f965ddab03a1179084810632305e1 >>> >>> commit 1b266ff1e45f965ddab03a1179084810632305e1 >>> Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> >>> Date: Tue Apr 19 17:40:11 2016 +0900 >>> >>> eo base - clean up base data struct formatting >>> >>> just a cleanup of the struct formatting/spacing >>> --- >>> src/lib/eo/eo_base_class.c | 30 +++++++++++++++--------------- >>> 1 file changed, 15 insertions(+), 15 deletions(-) >>> >>> diff --git a/src/lib/eo/eo_base_class.c b/src/lib/eo/eo_base_class.c >>> index 5baf582..4c5fe71 100644 >>> --- a/src/lib/eo/eo_base_class.c >>> +++ b/src/lib/eo/eo_base_class.c >>> @@ -16,32 +16,32 @@ typedef struct _Eo_Callback_Description >>> Eo_Callback_Description; >>> >>> typedef struct >>> { >>> - const char *id; >>> - const char *comment; >>> + const char *id; >>> + const char *comment; >>> } Eo_Base_Extension; >>> >>> typedef struct >>> { >>> - Eina_List *children; >>> - Eo *parent; >>> - Eina_List *parent_list; >>> + Eina_List *children; >>> + Eo *parent; >>> + Eina_List *parent_list; >>> >>> - Eina_Inlist *generic_data; >>> - Eo ***wrefs; >>> + Eina_Inlist *generic_data; >>> + Eo ***wrefs; >>> >>> - Eo_Base_Extension *extension; >>> - Eo_Callback_Description *callbacks; >>> - unsigned short walking_list; >>> - unsigned short event_freeze_count; >>> - Eina_Bool deletions_waiting : 1; >>> + Eo_Base_Extension *extension; >>> + Eo_Callback_Description *callbacks; >>> + unsigned short walking_list; >>> + unsigned short event_freeze_count; >>> + Eina_Bool deletions_waiting : 1; >>> } Eo_Base_Data; >>> >>> typedef struct >>> { >>> EINA_INLIST; >>> - Eina_Stringshare *key; >>> - void *data; >>> - Eina_Bool data_is_obj : 1; >>> + Eina_Stringshare *key; >>> + void *data; >>> + Eina_Bool data_is_obj : 1; >>> } Eo_Generic_Data_Node; >>> >>> >>> >> >> >> ------------------------------------------------------------------------------ >> Find and fix application performance issues faster with Applications Manager >> Applications Manager provides deep performance insights into multiple tiers >> of >> your business applications. It resolves application problems quickly and >> reduces your MTTR. Get your free trial! >> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
