hermet pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=80c42bc3a535da483b36213b43e7e8c108af073f

commit 80c42bc3a535da483b36213b43e7e8c108af073f
Author: Jee-Yong Um <jc9...@samsung.com>
Date:   Wed May 18 17:56:12 2016 +0900

    elm_list: perform a null check before accessing its member
    
    Summary:
    In inline function _elm_list_item_free, null check is performed
    after accessing its member.
    
    @fix
    
    Reviewers: cedric, Hermet
    
    Reviewed By: Hermet
    
    Subscribers: jpeg
    
    Differential Revision: https://phab.enlightenment.org/D3955
---
 src/lib/elementary/elm_list.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/lib/elementary/elm_list.c b/src/lib/elementary/elm_list.c
index 11c871d..5706b89 100644
--- a/src/lib/elementary/elm_list.c
+++ b/src/lib/elementary/elm_list.c
@@ -91,8 +91,12 @@ _is_no_select(Elm_List_Item_Data *it)
 static inline void
 _elm_list_item_free(Elm_List_Item_Data *it)
 {
+   Elm_Object_Item *eo_it;
+
+   if (!it) return;
+
    ELM_LIST_DATA_GET_FROM_ITEM(it, sd);
-   Elm_Object_Item *eo_it = it?EO_OBJ(it):NULL;
+   eo_it = EO_OBJ(it);
 
    if (sd->focused_item == eo_it)
      sd->focused_item = NULL;

-- 


Reply via email to