[EGIT] [core/efl] master 01/01: eolian: fix incorrect doxygen param generation

[Daniel Kolesa]

q66 pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=1a34d89d20c3b90b103481a501764eec522d35aa

commit 1a34d89d20c3b90b103481a501764eec522d35aa
Author: Daniel Kolesa <d.kol...@osg.samsung.com>
Date:   Thu Jun 9 14:39:06 2016 +0100

    eolian: fix incorrect doxygen param generation
    
    The first param on methods was skipped for some reason.
    
    @fix
---
 src/bin/eolian/docs_generator.c                 | 7 +------
 src/tests/eolian/data/class_simple_ref_eo.h     | 1 +
 src/tests/eolian/data/class_simple_ref_legacy.h | 1 +
 src/tests/eolian/data/docs_ref.h                | 1 +
 src/tests/eolian/data/docs_ref_legacy.h         | 1 +
 5 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/bin/eolian/docs_generator.c b/src/bin/eolian/docs_generator.c
index 886bf9e..8faddb2 100644
--- a/src/bin/eolian/docs_generator.c
+++ b/src/bin/eolian/docs_generator.c
@@ -382,11 +382,6 @@ docs_generate_function(const Eolian_Function *fid, 
Eolian_Function_Type ftype,
    if (ftype == EOLIAN_METHOD)
      {
         itr = eolian_function_parameters_get(fid);
-        if (!itr || !eina_iterator_next(itr, (void**)&par))
-          {
-             eina_iterator_free(itr);
-             itr = NULL;
-          }
      }
    else
      {
@@ -399,7 +394,7 @@ docs_generate_function(const Eolian_Function *fid, 
Eolian_Function_Type ftype,
          }
      }
 
-   if (itr && !eina_iterator_next(itr, (void**)&par))
+   if (!itr || !eina_iterator_next(itr, (void**)&par))
      {
         eina_iterator_free(itr);
         itr = NULL;
diff --git a/src/tests/eolian/data/class_simple_ref_eo.h 
b/src/tests/eolian/data/class_simple_ref_eo.h
index 9c66d57..43e96fc 100644
--- a/src/tests/eolian/data/class_simple_ref_eo.h
+++ b/src/tests/eolian/data/class_simple_ref_eo.h
@@ -53,6 +53,7 @@ EOAPI void evas_obj_simple_b_set(Eo *obj);
 /**
  * @brief comment foo
  *
+ * @param[in] a a
  * @param[in,out] b
  * @param[out] c
  * @param[in] d
diff --git a/src/tests/eolian/data/class_simple_ref_legacy.h 
b/src/tests/eolian/data/class_simple_ref_legacy.h
index 2150692..8ec66a6 100644
--- a/src/tests/eolian/data/class_simple_ref_legacy.h
+++ b/src/tests/eolian/data/class_simple_ref_legacy.h
@@ -44,6 +44,7 @@ EAPI void evas_object_simple_b_set(Class_Simple *obj);
 /**
  * @brief comment foo
  *
+ * @param[in] a a
  * @param[in,out] b
  * @param[out] c
  * @param[in] d
diff --git a/src/tests/eolian/data/docs_ref.h b/src/tests/eolian/data/docs_ref.h
index 4be8d3c..adc01ed 100644
--- a/src/tests/eolian/data/docs_ref.h
+++ b/src/tests/eolian/data/docs_ref.h
@@ -108,6 +108,7 @@ EOAPI int docs_prop_get(const Eo *obj);
 /**
  * @brief Method documentation.
  *
+ * @param[in] a Param documentation.
  * @param[out] b
  * @param[out] c Another param documentation.
  *
diff --git a/src/tests/eolian/data/docs_ref_legacy.h 
b/src/tests/eolian/data/docs_ref_legacy.h
index e804e3f..33314da 100644
--- a/src/tests/eolian/data/docs_ref_legacy.h
+++ b/src/tests/eolian/data/docs_ref_legacy.h
@@ -105,6 +105,7 @@ EAPI int docs_prop_get(const Docs *obj);
 /**
  * @brief Method documentation.
  *
+ * @param[in] a Param documentation.
  * @param[out] b
  * @param[out] c Another param documentation.
  *

--