On 16/06/16 10:47, Carsten Haitzler wrote: > On Thu, 16 Jun 2016 14:28:22 +0900 Jean-Philippe André <j...@videolan.org> > said: > > >>>> The ON_HOLD flag, now called efl_event_processed_get/set() is a better >>>> approach to stop processing events. >>> >>> That is off topic, but seriously something we should consider asap if >>> we want to drop the return type of event. I have not any case in mind >>> where returning EINA_FALSE make sense. Should we drop it ? >>> >> >> I am also thinking we should drop it. >> Pretty sure the few places that return EINA_FALSE right now are actually >> mistakes and sources of bugs. > > i think so too. drop the return. >
The return is mega useful, though I'm open to implementing it differently. The return is there so you can filter events. We currently have things like "on_hold" in input events to mark an event has been processed and should stop propagating, but the return lets you stop the callback. I guess we can change it to be "eo_event_callback_stop(obj)". Btw, it shouldn't be a bool, there are defines for the return values. I should have typedeffed the type. I'm open to changing to eo_event_callback_stop though, just let me know. Grep for EO_EVENT_STOP, it is already used by code, even code I didn't write. :) -- Tom. ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohomanageengine _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
