[EGIT] [core/efl] master 01/01: ecore-evas: Fix error handling issues in wayland_shm engine

[Chris Michael]

devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=1fb3c3328604c56d20ea4a0e35925d4b9f94b185

commit 1fb3c3328604c56d20ea4a0e35925d4b9f94b185
Author: Chris Michael <cpmich...@osg.samsung.com>
Date:   Thu Jun 30 10:51:29 2016 -0400

    ecore-evas: Fix error handling issues in wayland_shm engine
    
    This patch fixes 2 Coverity issues where engine_info_set was being
    called, but the return was never being checked.
    
    Fixes Coverity CID1357141 and CID1357142
    
    @fix
    
    Signed-off-by: Chris Michael <cpmich...@osg.samsung.com>
---
 src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c 
b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
index e18c06c..05e60f6 100644
--- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
+++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
@@ -443,7 +443,8 @@ _ecore_evas_wl_show(Ecore_Evas *ee)
              if ((!einfo->info.wl_surface) || (einfo->info.wl_surface != surf))
                {
                   einfo->info.wl_surface = surf;
-                  evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo);
+                  if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info 
*)einfo))
+                    ERR("Failed to set Evas Engine Info for '%s'", ee->driver);
                   evas_damage_rectangle_add(ee->evas, 0, 0, ee->w + fw, ee->h 
+ fh);
                }
           }
@@ -482,7 +483,10 @@ _ecore_evas_wl_hide(Ecore_Evas *ee)
    if (einfo)
      {
         einfo->info.wl_surface = NULL;
-        evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo);
+        if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo))
+          {
+             ERR("Failed to set Evas Engine Info for '%s'", ee->driver);
+          }
      }
 
    if (wdata->win) 

--