devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=ff7a5e4f1b1286b1226fb0a9a1729759d1f72e18

commit ff7a5e4f1b1286b1226fb0a9a1729759d1f72e18
Author: Chris Michael <cpmich...@osg.samsung.com>
Date:   Thu Jun 30 11:14:40 2016 -0400

    ecore-wl2: Fix issue where hash would not get destroyed on error
    
    Coverity reports that we could not reach the eina_hash_free here on
    erorr condition. This was due to an erroneous return NULL above the if
    (hash_create) check.
    
    Fixes Coverity CID1357171
    
    @fix
    
    Signed-off-by: Chris Michael <cpmich...@osg.samsung.com>
---
 src/lib/ecore_wl2/ecore_wl2_display.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/lib/ecore_wl2/ecore_wl2_display.c 
b/src/lib/ecore_wl2/ecore_wl2_display.c
index cdc859c..0df55f5 100644
--- a/src/lib/ecore_wl2/ecore_wl2_display.c
+++ b/src/lib/ecore_wl2/ecore_wl2_display.c
@@ -695,7 +695,6 @@ connect_err:
    eina_hash_free(ewd->globals);
    free(ewd->name);
    free(ewd);
-   return NULL;
 
    if (hash_create)
      {

-- 


Reply via email to