hermet pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=19b291586336107c0d4d4cb02c44c7bc82f7ea1b
commit 19b291586336107c0d4d4cb02c44c7bc82f7ea1b Author: Wonki Kim <wonki_....@samsung.com> Date: Fri Jul 8 21:28:18 2016 +0900 elm: Fix potential null point dereferences. Summary: If every assigning logics to enginelist is not performed some how, system will crash because the first parameter of strcmp is null. Test Plan: N/A Reviewers: Hermet Reviewed By: Hermet Subscribers: cedric, Hermet, raster, jpeg Differential Revision: https://phab.enlightenment.org/D4149 --- src/lib/elementary/efl_ui_win.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/lib/elementary/efl_ui_win.c b/src/lib/elementary/efl_ui_win.c index 0293ea9..ebe283e 100644 --- a/src/lib/elementary/efl_ui_win.c +++ b/src/lib/elementary/efl_ui_win.c @@ -4210,10 +4210,8 @@ _elm_win_finalize_internal(Eo *obj, Efl_Ui_Win_Data *sd, const char *name, Elm_W #endif } } - enginelist[p++] = NULL; - for (i = 0; i < 30; i++) + for (i = 0; i < p; i++) { - if ((i > 0) && (!enginelist[i])) break; if (!strcmp(enginelist[i], ELM_SOFTWARE_X11)) tmp_sd.ee = ecore_evas_software_x11_new(NULL, 0, 0, 0, 1, 1); else if (!strcmp(enginelist[i], ELM_OPENGL_X11)) --