Hello! Yeah, we are understand that this buggy code should be rewritten in different way. Tho, sadly don't have much time to investigate and quickly apply another fix to it.
We needed to do that in threads because otherwise it would freeze our beautiful project-opening-animation C: So it was kinda quick-fix-for-now. BUT! We found some solution, tried it up, it seems working, just need time on applying it to eflete code. So that "ifdef WIN32" fix is quite temporary decision to just to make it buildable on Windows. I will work on it as soon as will be available to! On 07/19/2016 05:37 PM, Cedric BAIL wrote: > On Jul 19, 2016 00:12, "Vitalii Vorobiov" <[email protected]> wrote: >> rimmed pushed a commit to branch master. >> >> > http://git.enlightenment.org/tools/eflete.git/commit/?id=ea8b853dc0c6cb4b168aca9a3139b02e891fd037 >> commit ea8b853dc0c6cb4b168aca9a3139b02e891fd037 >> Author: Vitalii Vorobiov <[email protected]> >> Date: Fri Jul 15 12:27:57 2016 +0300 >> >> project_manager: do not use sigset under WIN32 >> >> @fix > This is clearly not the proper fix at all. It has been discussed before, > but this code is buggy and shouldn't use thread in the first place. > >> --- >> src/bin/project_manager/project_manager.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/src/bin/project_manager/project_manager.c > b/src/bin/project_manager/project_manager.c >> index 2363b3c..9ed03f6 100644 >> --- a/src/bin/project_manager/project_manager.c >> +++ b/src/bin/project_manager/project_manager.c >> @@ -549,10 +549,12 @@ _project_import_edc(void *data, >> * | if group has scripts it waits for child(compiler) >> * | process termination, but never receives it because of blocked > SIGCHLD >> */ >> +#ifndef _WIN32 >> sigset_t oldset, newset; >> sigemptyset(&newset); >> sigaddset(&newset, SIGCHLD); >> sigprocmask(SIG_UNBLOCK, &newset, &oldset); >> +#endif >> >> Eina_Bool send_end_child; >> Eina_Bool send_end = (data) ? (*(Eina_Bool *)data) : true; >> @@ -1602,10 +1604,12 @@ _release_export(void *data __UNUSED__, >> * | if group has scripts it waits for child(compiler) >> * | process termination, but never receives it because of blocked > SIGCHLD >> */ >> +#ifndef _WIN32 >> sigset_t oldset, newset; >> sigemptyset(&newset); >> sigaddset(&newset, SIGCHLD); >> sigprocmask(SIG_UNBLOCK, &newset, &oldset); >> +#endif >> >> Eina_Tmpstr *tmp_dirname; >> Eina_Strbuf *cmd; >> @@ -1794,10 +1798,12 @@ _enventor_save(void *data __UNUSED__, >> * | if group has scripts it waits for child(compiler) >> * | process termination, but never receives it because of blocked > SIGCHLD >> */ >> +#ifndef _WIN32 >> sigset_t oldset, newset; >> sigemptyset(&newset); >> sigaddset(&newset, SIGCHLD); >> sigprocmask(SIG_UNBLOCK, &newset, &oldset); >> +#endif >> >> Ecore_Event_Handler *cb_msg_stdout = NULL, >> *cb_msg_stderr = NULL; >> >> -- >> >> >> > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic > patterns at an interface-level. Reveals which users, apps, and protocols are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity planning > reports.http://sdm.link/zohodev2dev > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
