[EGIT] [core/efl] master 01/01: eldbus: Check return value and error out if necessary

[Chris Michael]

devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=fb09df7977d6038d0c422494dd2d9926e70a89a9

commit fb09df7977d6038d0c422494dd2d9926e70a89a9
Author: Chris Michael <cp.mich...@samsung.com>
Date:   Thu Jul 21 12:50:19 2016 -0400

    eldbus: Check return value and error out if necessary
    
    Coverity reports that we do not check the return value of
    _eldbus_model_proxy_load here. We likely should be checking that in
    case the model proxy fails to load so we can return proper values here.
    
    Fixes Coverity CID1355233
    
    @fix
    
    Signed-off-by: Chris Michael <cp.mich...@samsung.com>
---
 src/lib/eldbus/eldbus_model_proxy.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/lib/eldbus/eldbus_model_proxy.c 
b/src/lib/eldbus/eldbus_model_proxy.c
index 43a3779..430ccb2 100644
--- a/src/lib/eldbus/eldbus_model_proxy.c
+++ b/src/lib/eldbus/eldbus_model_proxy.c
@@ -98,9 +98,13 @@ static Eina_Array const *
 _eldbus_model_proxy_efl_model_properties_get(Eo *obj EINA_UNUSED,
                                                Eldbus_Model_Proxy_Data *pd)
 {
+   Eina_Bool ret;
+
    EINA_SAFETY_ON_NULL_RETURN_VAL(pd, NULL);
 
-   _eldbus_model_proxy_load(pd);
+   ret = _eldbus_model_proxy_load(pd);
+   if (!ret) return NULL;
+
    return pd->properties_array;
 }
 

--