Hi, On 4 August 2016 at 00:34, Christopher Michael <cpmich...@osg.samsung.com> wrote:
> On 08/03/2016 10:58 AM, Gustavo Sverzut Barbieri wrote: > > On Wed, Aug 3, 2016 at 10:01 AM, Chris Michael <cp.mich...@samsung.com> > wrote: > > [...] > >> +#ifndef GL_GLES > >> if (v1 >= 360) gw->detected.noext_glXCreatePixmap = 1; > >> +#endif > >> } > >> } > >> else > >> @@ -558,7 +560,12 @@ try_gles2: > >> gw->detected.msaa = val; > >> #endif > >> > >> +#ifndef GL_GLES > >> eng_gl_symbols(gw->detected.noext_glXCreatePixmap); > >> +#else > >> + eng_gl_symbols(EINA_FALSE); // EINA_FALSE is ignored anyway for > gl_gles > >> +#endif > > > > Actually this gw->detected.noext_glXCreatePixmap is only used in this > > function, thus I wonder why not a local variable instead of adding a > > member to the struct and then ifdef it. > > > > > > You'd have to ask the original author of the code (jpeg). I just fixed > the build break. > Yeah. No good reason, really. Also, sorry for the break. No point in changing this now, I have a large pending patch that fixes how we resolve extensions, because there was a huge misconception about GetProcAddress in evas gl code. So this variable will not be needed anymore anyway. -- Jean-Philippe André ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
