jayji pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b6b82896365e6de43aca745385963a0673f18d46

commit b6b82896365e6de43aca745385963a0673f18d46
Author: Jean Guyomarc'h <[email protected]>
Date:   Fri Aug 12 16:20:34 2016 +0200

    elementary: fix segmentation faults when using elm_prefs
    
    There are several cases of failure:
    - if regex is NULL, regfree(regex) may lead to segmentation fault
      (undefined behaviour, as specified in POSIX.1)
    - if regex is not NULL, there are cases of use-after-free.
    
    @fix
---
 src/modules/elementary/prefs/elm_entry.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/modules/elementary/prefs/elm_entry.c 
b/src/modules/elementary/prefs/elm_entry.c
index 5253202..966838e 100644
--- a/src/modules/elementary/prefs/elm_entry.c
+++ b/src/modules/elementary/prefs/elm_entry.c
@@ -207,7 +207,6 @@ elm_prefs_entry_add(const Elm_Prefs_Item_Iface *iface 
EINA_UNUSED,
    elm_entry_markup_filter_append(obj, elm_entry_filter_limit_size, &limit);
    elm_layout_text_set(obj, NULL, spec.s.placeholder);
 
-   regfree(regex);
    return obj;
 }
 

-- 


Reply via email to