Hello, i would like to get back to this.
On Tue, Nov 01, 2016 at 11:48:50AM -0700, Jee-Yong Um wrote: > cedric pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=0fd144550877ff0a6f413c025685b7e7d63e6535 > > commit 0fd144550877ff0a6f413c025685b7e7d63e6535 > Author: Jee-Yong Um <con...@gmail.com> > Date: Tue Nov 1 10:59:09 2016 -0700 > > edje.object: implement Efl.Observer interface > > Summary: > To remove duplicated lines to handle edje class (color, text, size), > observer interface is implemented to Edje.Object. > > Reviewers: jpeg, cedric > > Reviewed By: cedric > > Subscribers: bu5hm4n, cedric > > Differential Revision: https://phab.enlightenment.org/D4359 > > Signed-off-by: Cedric BAIL <ced...@osg.samsung.com> > --- > src/Makefile_Efl.am | 3 + > src/lib/edje/edje_load.c | 8 +- > src/lib/edje/edje_main.c | 45 +++- > src/lib/edje/edje_object.eo | 4 +- > src/lib/edje/edje_private.h | 19 +- > src/lib/edje/edje_smart.c | 50 ++++ > src/lib/edje/edje_text.c | 8 +- > src/lib/edje/edje_textblock_styles.c | 6 +- > src/lib/edje/edje_util.c | 441 > ++++--------------------------- > src/lib/efl/Efl.h | 3 + > src/lib/efl/interfaces/efl_observable.eo | 63 +++++ > src/lib/efl/interfaces/efl_observer.c | 259 ++++++++++++++++++ > src/lib/efl/interfaces/efl_observer.eo | 15 ++ > src/lib/efl/interfaces/efl_types.eot | 6 + > 14 files changed, 514 insertions(+), 416 deletions(-) > [snip] > +#include "efl_observable.eo.c" > +#include "efl_observer.eo.c" > diff --git a/src/lib/efl/interfaces/efl_observer.eo > b/src/lib/efl/interfaces/efl_observer.eo > new file mode 100644 > index 0000000..a0d4ffe > --- /dev/null > +++ b/src/lib/efl/interfaces/efl_observer.eo > @@ -0,0 +1,15 @@ > +interface Efl.Observer { > + methods { > + update @virtual_pure { > + [[Update observer according to the changes of observable object. > + > + @since 1.19]] > + params { > + /* FIXME: obs should be Efl.Observable, but cyclic dependency > error occurs. */ > + @in obs: Efl.Object; [[An observable object]] It looks like this is never going to change. So i guess its quite dangerous to leave this interface like this, since its not going to work like this. And the interface itself probebly needs to be defined in a way that it works with the way eolian handles cyclic dependencies Greetings Marcel Hollerbach ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
