Hello.

On 08/12/16 14:35, Stefan Schmidt wrote:
> Hello.
>
> On 08/12/16 13:14, Andrii Kroitor wrote:
>> lorddrew pushed a commit to branch master.
>>
>> http://git.enlightenment.org/core/efl.git/commit/?id=c505b754ce43a711024f6bad6150c7294e067046
>>
>> commit c505b754ce43a711024f6bad6150c7294e067046
>> Author: Andrii Kroitor <an.kroi...@samsung.com>
>> Date:   Fri Dec 2 12:01:41 2016 +0200
>>
>>     exore_exe: fix from @raster
>> ---
>>  src/lib/ecore/ecore_exe_private.h |  23 +-
>>  src/lib/ecore/ecore_exe_win32.c   | 665 
>> +++++++++++++++++++-------------------
>>  2 files changed, 337 insertions(+), 351 deletions(-)
>
> Having a short commit message is one think but the one above tells us
> nothing. I felt tempted to just revert it based on that fact. Especially
> if one sees how big the commit is and how much code it changes.
>
> You have commit rights now and I expect better from people that got them.

My apologies. Just seen the revert after I have sent the mail.

regards
Stefan Schmidt

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to