Hello. On 01/02/17 14:39, Gustavo Sverzut Barbieri wrote: > On Wed, Feb 1, 2017 at 11:24 AM, Stefan Schmidt > <ste...@datenfreihafen.org> wrote: >> stefan pushed a commit to branch master. >> >> http://git.enlightenment.org/core/efl.git/commit/?id=592f356fe5cc64ac6e790d2014edfd11dcfc17a5 >> >> commit 592f356fe5cc64ac6e790d2014edfd11dcfc17a5 >> Author: Stefan Schmidt <ste...@osg.samsung.com> >> Date: Wed Feb 1 14:22:11 2017 +0100 >> >> cmake: remove dependency on libjpeg in eet as it is handled in common >> --- >> src/lib/eet/CMakeLists.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/lib/eet/CMakeLists.txt b/src/lib/eet/CMakeLists.txt >> index 813f293..76b71a4 100644 >> --- a/src/lib/eet/CMakeLists.txt >> +++ b/src/lib/eet/CMakeLists.txt >> @@ -2,7 +2,7 @@ set(DESCRIPTION "Library for speedy data storage, retrieval, >> and compression") >> >> set(PKG_CONFIG_REQUIRES_PRIVATE >> zlib>=1.2.3 >> - libjpeg >> + #libjpeg is hard to find. there is a cmake module that does find it. and >> thats checked in common.cmake >> ) > > You got this wrong, this is not just to check, it's to use. Now you'll > have cmake build of eet with undefined symbols. > > This is also used to generate .pc files, see my other email.
Fair enough. I actually try to understand the cmake stuff at all right now and trying it out. Pretty likely my fixes are off here. And indeed I run into missing symbols now (emile not eet in this case) Scanning dependencies of target ecore_con-bin [ 79%] Building C object CMakeFiles/ecore_con-bin.dir/src/bin/ecore_con/efl_net_proxy_helper.c.o [ 79%] Linking C executable lib64/ecore_con/utils/v-1.18/efl_net_proxy_helper /home/stefan/EFL/efl/build/lib64/libemile.so.1: undefined reference to `jpeg_resync_to_restart' /home/stefan/EFL/efl/build/lib64/libeet.so.1: undefined reference to `jpeg_std_error' /home/stefan/EFL/efl/build/lib64/libemile.so.1: undefined reference to `jpeg_CreateDecompress' /home/stefan/EFL/efl/build/lib64/libeet.so.1: undefined reference to `jpeg_start_compress' /home/stefan/EFL/efl/build/lib64/libeet.so.1: undefined reference to `jpeg_set_quality' /home/stefan/EFL/efl/build/lib64/libemile.so.1: undefined reference to `jpeg_read_header' /home/stefan/EFL/efl/build/lib64/libemile.so.1: undefined reference to `jpeg_destroy_decompress' /home/stefan/EFL/efl/build/lib64/libemile.so.1: undefined reference to `jpeg_calc_output_dimensions' /home/stefan/EFL/efl/build/lib64/libeet.so.1: undefined reference to `jpeg_finish_compress' /home/stefan/EFL/efl/build/lib64/libeet.so.1: undefined reference to `jpeg_destroy_compress' /home/stefan/EFL/efl/build/lib64/libemile.so.1: undefined reference to `jpeg_finish_decompress' /home/stefan/EFL/efl/build/lib64/libeet.so.1: undefined reference to `jpeg_set_defaults' /home/stefan/EFL/efl/build/lib64/libemile.so.1: undefined reference to `jpeg_start_decompress' /home/stefan/EFL/efl/build/lib64/libeet.so.1: undefined reference to `jpeg_write_scanlines' /home/stefan/EFL/efl/build/lib64/libeet.so.1: undefined reference to `jpeg_CreateCompress' /home/stefan/EFL/efl/build/lib64/libemile.so.1: undefined reference to `jpeg_read_scanlines' collect2: error: ld returned 1 exit status CMakeFiles/ecore_con-bin.dir/build.make:96: recipe for target 'lib64/ecore_con/utils/v-1.18/efl_net_proxy_helper' failed make[2]: *** [lib64/ecore_con/utils/v-1.18/efl_net_proxy_helper] Error 1 CMakeFiles/Makefile2:1276: recipe for target 'CMakeFiles/ecore_con-bin.dir/all' failed make[1]: *** [CMakeFiles/ecore_con-bin.dir/all] Error 2 Makefile:138: recipe for target 'all' failed make: *** [all] Error 2 Given that we seem to need the FindLibjpeg macro we might need to go the full route to make sure our build system understand things correctly. regards Stefan Schmidt ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
