Hello. On 03/02/2017 05:52 PM, Guilherme Íscaro wrote: > Hello all, > > So, about the multi-seat/cursos API. > > >> Added APIs: >> >> Ecore_Evas.h, libecore_evas.so.1.19.0 >> ecore_evas_cursor_device_get ( Ecore_Evas const* ee, Efl_Input_Device* >> pointer, Evas_Object** obj, int* layer, int* hot_x, int* hot_y ) >> ecore_evas_object_cursor_device_set ( Ecore_Evas* ee, Efl_Input_Device* >> pointer, Evas_Object* obj, int layer, int hot_x, int hot_y ) >> >> Why has the set a _object_ in the function name and the get not? >> >> > I just followed the existing API pattern. If you take a look at the > Ecore_Evas.h, you will see the following functions: > * ecore_evas_object_cursor_set() > * ecore_evas_cursor_set() > * ecore_evas_cursor_get() > > There's not ecore_evas_object_cursor_get(), only set.
What confuses me is that you have * ecore_evas_object_cursor_device_set * ecore_evas_cursor_device_get If you compare that to your above example it misses a * ecore_evas_cursor_device_set You even have a doxygen ref to it in the doc from ecore_evas_cursor_device_get. :) > > >> >> edje_object.eo.legacy.h, libedje.so.1.19.0 >> edje_object_seat_get ( Edje_Object const* obj, Eina_Stringshare* name ) >> edje_object_seat_name_get ( Edje_Object const* obj, Efl_Input_Device* >> device ) >> >> efl_canvas_object.eo.legacy.h, libevas.so.1.19.0 >> evas_object_pointer_device_in_get ( Efl_Canvas_Object const* obj, >> Efl_Input_Device* pointer ) >> evas_object_pointer_in_get ( Efl_Canvas_Object const* obj ) >> evas_object_pointer_mode_by_device_get ( Efl_Canvas_Object const* obj, >> Efl_Input_Device* dev ) >> evas_object_pointer_mode_by_device_set ( Efl_Canvas_Object* obj, >> Efl_Input_Device* dev, enum Efl_Input_Object_Pointer_Mode pointer_mode ) >> evas_object_seat_focus_add ( Efl_Canvas_Object* obj, Efl_Input_Device* >> seat ) >> evas_object_seat_focus_check ( Efl_Canvas_Object* obj, Efl_Input_Device* >> seat ) >> evas_object_seat_focus_del ( Efl_Canvas_Object* obj, Efl_Input_Device* >> seat ) >> evas_object_seat_focus_get ( Efl_Canvas_Object const* obj ) >> >> Is the seat stuff supposed to be exposed to legacy? I can see them used >> in src/lib/edje/edje_program.c, but I wonder if they should wait for >> interfaces or should be exposed now. >> >> >> > Indeed, they should not be exposed. I created a pull request, please take a > look when you can (https://phab.enlightenment.org/D4696). I also pushed a > branch at devs/iscaro/legacy_api. Thanks for getting this sorted out. regards Stefan Schmidt ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
