raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=706c7f9e3b1080aedd62de6fdf2c708f56eded8d

commit 706c7f9e3b1080aedd62de6fdf2c708f56eded8d
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
Date:   Tue Apr 18 16:58:04 2017 +0900

    genlist - fix coverity complaint about null check
    
    we checked for null and then just used a null return later inthe loop.
    this fixes that. this should fix CID 1360955
---
 src/lib/elementary/elm_genlist.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_genlist.c
index 360bbcb..b657e57 100644
--- a/src/lib/elementary/elm_genlist.c
+++ b/src/lib/elementary/elm_genlist.c
@@ -7745,8 +7745,9 @@ _filter_queue_process(Elm_Genlist_Data *sd)
    for (n = 0; ((sd->filter_queue) && (sd->processed_count < ITEM_QUEUE_MAX)); 
n++)
      {
         it = eina_list_data_get(sd->filter_queue);
+        if (!it) break;
         //FIXME: This is added as a fail safe code for items not yet processed.
-        if (it && it->item->queued)
+        if (it->item->queued)
           {
              sd->filter_queue = eina_list_remove_list
                               (sd->filter_queue, sd->filter_queue);

-- 


Reply via email to