On Mon, 29 May 2017 08:46:53 -0700 Cedric BAIL <cedric.b...@free.fr> said:

> On May 29, 2017 02:26, "Carsten Haitzler" <ras...@rasterman.com> wrote:
> 
> raster pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=
> fa944c700eeaa909ff4883296fbf484fcbb41e65
> 
> commit fa944c700eeaa909ff4883296fbf484fcbb41e65
> Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
> Date:   Mon May 29 18:01:37 2017 +0900
> 
>     evas - adjust code in evas init to keep threaded gl patches applying
> 
> 
> This code is obviously wrong, do you plan to land the gl patch and revert
> soon it soon ? Otherwise, it would be better kept in a branch.

how is it actually wrong?  other than the log timing wont include the map init?
not exactly much of an issue - doesnt break anything... it's not like most devs
even know this is being done let alone look a these init logs and look at init
timings... :)

the patches still have issues last round (i was getting back to it yesterday)

> ---
>  src/lib/evas/canvas/evas_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lib/evas/canvas/evas_main.c b/src/lib/evas/canvas/evas_
> main.c
> index 0229e0d3b2..cda9551c1a 100644
> --- a/src/lib/evas/canvas/evas_main.c
> +++ b/src/lib/evas/canvas/evas_main.c
> @@ -88,12 +88,12 @@ evas_init(void)
>     if (!evas_thread_init())
>       goto shutdown_filter;
> 
> -   _efl_gfx_map_init();
> -
>     eina_log_timing(_evas_log_dom_global,
>                    EINA_LOG_STATE_STOP,
>                    EINA_LOG_STATE_INIT);
> 
> +   _efl_gfx_map_init();
> +
>     return _evas_init_count;
> 
>   shutdown_filter:
> 
> --
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to