2017-07-13 16:35 GMT+09:00 Stefan Schmidt <ste...@osg.samsung.com>: > Hello. > > On 07/13/2017 04:18 AM, Amitesh Singh wrote: > >> ami pushed a commit to branch master. >> >> http://git.enlightenment.org/core/efl.git/commit/?id=98b9bb0 >> da519c3ac9eb1c33caad79e54349e5a7f >> >> commit 98b9bb0da519c3ac9eb1c33caad79e54349e5a7f >> Author: Amitesh Singh <amitesh...@samsung.com> >> Date: Thu Jul 13 11:16:48 2017 +0900 >> >> win: fix compiler warning >> --- >> src/lib/elementary/efl_ui_win.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/lib/elementary/efl_ui_win.c >> b/src/lib/elementary/efl_ui_win.c >> index 90bdb2c145..cd54c583ca 100644 >> --- a/src/lib/elementary/efl_ui_win.c >> +++ b/src/lib/elementary/efl_ui_win.c >> @@ -5339,7 +5339,7 @@ _efl_ui_win_elm_widget_focus_manager_factory(Eo >> *obj EINA_UNUSED, Efl_Ui_Win_Dat >> } >> EOLIAN static void >> -_efl_ui_win_efl_object_destructor(Eo *obj EINA_UNUSED, Efl_Ui_Win_Data >> *pd) >> +_efl_ui_win_efl_object_destructor(Eo *obj EINA_UNUSED, Efl_Ui_Win_Data >> *pd EINA_UNUSED) >> { >> #ifdef HAVE_ELEMENTARY_WL2 >> if (pd->type == ELM_WIN_FAKE) >> > > As you can see in this line pd is actually used with HAVE_ELEMENTARY_WL2. >
I think the hint EINA_UNUSED is fine here, as the only other solution is something like: #else (void) pd; #endif Which I find uglier. EINA_UNUSED does not change anything in the binary code. -- Jean-Philippe André ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
