jaehyun pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=f2082c0412a5e1df6b1a53e209125e7fe37dccf8
commit f2082c0412a5e1df6b1a53e209125e7fe37dccf8
Author: JinYong Park <j4939.p...@samsung.com>
Date: Fri Aug 4 15:33:27 2017 +0900
layout: fix "elm,state,text,hidden" signal never be emitted
Summary:
In _elm_layout_text_set function, text_signal_emit is called.
But in that case, check text whether it is null or not null before call
signal_emit.
So "text" is not null always, and text_signal_emit's parameter "visible"
is also always EINA_TRUE.
Reviewers: Jaehyun_Cho, cedric, jpeg
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5049
---
src/lib/elementary/elm_layout.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lib/elementary/elm_layout.c b/src/lib/elementary/elm_layout.c
index 0a78126c4c..790860f605 100644
--- a/src/lib/elementary/elm_layout.c
+++ b/src/lib/elementary/elm_layout.c
@@ -1231,6 +1231,7 @@ _elm_layout_text_set(Eo *obj, Elm_Layout_Smart_Data *sd,
const char *part, const
{
if (!text)
{
+ _text_signal_emit(sd, sub_d, EINA_FALSE);
eina_stringshare_del(sub_d->part);
free(sub_d);
edje_object_part_text_escaped_set
@@ -1258,7 +1259,7 @@ _elm_layout_text_set(Eo *obj, Elm_Layout_Smart_Data *sd,
const char *part, const
sd->subs = eina_list_append(sd->subs, sub_d);
}
- _text_signal_emit(sd, sub_d, !!text);
+ _text_signal_emit(sd, sub_d, EINA_TRUE);
elm_layout_sizing_eval(obj);
--
