discomfitor pushed a commit to branch enlightenment-0.21.
http://git.enlightenment.org/core/enlightenment.git/commit/?id=73a78b5a1a88ec424e3f19663e6661ac88cbc4a5
commit 73a78b5a1a88ec424e3f19663e6661ac88cbc4a5
Author: Al Poole <nets...@gmail.com>
Date: Sun Aug 13 09:52:02 2017 +0900
Efm: file properties, fix widget sizing issue.
Summary: This fixes the erroneous sizing of labels in Efm preview dialogues.
Reviewers: zmike!
Subscribers: stephenmhouston, cedric, raster
Differential Revision: https://phab.enlightenment.org/D5093
---
src/bin/e_fm_prop.c | 42 ++++++++++++++++++++++++------------------
1 file changed, 24 insertions(+), 18 deletions(-)
diff --git a/src/bin/e_fm_prop.c b/src/bin/e_fm_prop.c
index 6d9a222ee..fe54e0219 100644
--- a/src/bin/e_fm_prop.c
+++ b/src/bin/e_fm_prop.c
@@ -389,69 +389,75 @@ _basic_create_widgets(E_Config_Dialog *cfd, Evas *evas,
E_Config_Dialog_Data *cf
ot = e_widget_table_add(e_win_evas_win_get(evas), 0);
+ of = e_widget_frametable_add(evas, _("General"), 1);
+
ob = e_widget_label_add(evas, _("Name:"));
- e_widget_table_object_append(ot, ob, 0, 0, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 0, 0, 1, 1, 1, 0, 1, 0);
ob = e_widget_entry_add(win, &(cfdata->file), NULL, NULL, NULL);
e_widget_size_min_get(ob, NULL, &mh);
e_widget_size_min_set(ob, 140, mh);
e_widget_entry_readonly_set(ob, 1);
- e_widget_table_object_append(ot, ob, 1, 0, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 1, 0, 1, 1, 1, 0, 1, 0);
ob = e_widget_label_add(evas, _("Location:"));
- e_widget_table_object_append(ot, ob, 0, 1, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 0, 1, 1, 1, 1, 0, 1, 0);
ob = e_widget_entry_add(win, &(cfdata->location), NULL, NULL, NULL);
e_widget_size_min_get(ob, NULL, &mh);
e_widget_size_min_set(ob, 140, mh);
e_widget_entry_readonly_set(ob, 1);
- e_widget_table_object_append(ot, ob, 1, 1, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 1, 1, 1, 1, 1, 0, 1, 0);
ob = e_widget_label_add(evas, _("Size:"));
- e_widget_table_object_append(ot, ob, 0, 2, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 0, 2, 1, 1, 1, 0, 1, 0);
ob = e_widget_entry_add(win, &(cfdata->size), NULL, NULL, NULL);
e_widget_size_min_get(ob, NULL, &mh);
e_widget_size_min_set(ob, 140, mh);
e_widget_entry_readonly_set(ob, 1);
- e_widget_table_object_append(ot, ob, 1, 2, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 1, 2, 1, 1, 1, 0, 1, 0);
ob = e_widget_label_add(evas, _("Occupied blocks on disk:"));
- e_widget_table_object_append(ot, ob, 0, 3, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 0, 3, 1, 1, 1, 0, 1, 0);
ob = e_widget_entry_add(win, &(cfdata->blocks), NULL, NULL, NULL);
e_widget_size_min_get(ob, NULL, &mh);
e_widget_size_min_set(ob, 140, mh);
e_widget_entry_readonly_set(ob, 1);
- e_widget_table_object_append(ot, ob, 1, 3, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 1, 3, 1, 1, 1, 0, 1, 0);
ob = e_widget_label_add(evas, _("Last Accessed:"));
- e_widget_table_object_append(ot, ob, 0, 4, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 0, 4, 1, 1, 1, 0, 1, 0);
ob = e_widget_entry_add(win, &(cfdata->acc_date), NULL, NULL, NULL);
e_widget_size_min_get(ob, NULL, &mh);
e_widget_size_min_set(ob, 140, mh);
e_widget_entry_readonly_set(ob, 1);
- e_widget_table_object_append(ot, ob, 1, 4, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 1, 4, 1, 1, 1, 0, 1, 0);
ob = e_widget_label_add(evas, _("Last Modified:"));
- e_widget_table_object_append(ot, ob, 0, 5, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 0, 5, 1, 1, 1, 0, 1, 0);
ob = e_widget_entry_add(win, &(cfdata->mod_date), NULL, NULL, NULL);
e_widget_size_min_get(ob, NULL, &mh);
e_widget_size_min_set(ob, 140, mh);
e_widget_entry_readonly_set(ob, 1);
- e_widget_table_object_append(ot, ob, 1, 5, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 1, 5, 1, 1, 1, 0, 1, 0);
ob = e_widget_label_add(evas, _("Last Modified Permissions:"));
- e_widget_table_object_append(ot, ob, 0, 6, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 0, 6, 1, 1, 1, 0, 1, 0);
ob = e_widget_entry_add(win, &(cfdata->pms_date), NULL, NULL, NULL);
e_widget_size_min_get(ob, NULL, &mh);
e_widget_size_min_set(ob, 140, mh);
e_widget_entry_readonly_set(ob, 1);
- e_widget_table_object_append(ot, ob, 1, 6, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 1, 6, 1, 1, 1, 0, 1, 0);
ob = e_widget_label_add(evas, _("File Type:"));
- e_widget_table_object_append(ot, ob, 0, 7, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 0, 7, 1, 1, 1, 0, 1, 0);
ob = e_widget_entry_add(win, &(cfdata->mime), NULL, NULL, NULL);
e_widget_size_min_get(ob, NULL, &mh);
e_widget_size_min_set(ob, 140, mh);
e_widget_entry_readonly_set(ob, 1);
- e_widget_table_object_append(ot, ob, 1, 7, 1, 1, 1, 0, 1, 0);
+ e_widget_frametable_object_append(of, ob, 1, 7, 1, 1, 1, 0, 1, 0);
+
+ e_widget_table_object_append(ot, of, 0, 0, 1, 1, 1, 1, 1, 1);
+ e_widget_table_object_append(o, ot, 1, 0, 0, 1, 1, 1, 1, 1);
+
of = e_widget_frametable_add(evas, _("Permissions"), 0);
ob = e_widget_entry_add(win, &(cfdata->owner), NULL, NULL, NULL);
@@ -483,10 +489,10 @@ _basic_create_widgets(E_Config_Dialog *cfd, Evas *evas,
E_Config_Dialog_Data *cf
ob = e_widget_check_add(evas, _("execute"), &(cfdata->others_exec));
e_widget_frametable_object_append(of, ob, 2, 3, 1, 1, 1, 1, 1, 1);
- e_widget_table_object_append(ot, of, 0, 8, 2, 1, 1, 0, 1, 0);
-
+ e_widget_table_object_append(ot, of, 0, 1, 1, 1, 1, 1, 1, 1);
e_widget_table_object_append(o, ot, 0, 0, 1, 1, 1, 1, 1, 1);
+
of = e_widget_frametable_add(evas, _("Preview"), 0);
ot = e_widget_table_add(e_win_evas_win_get(evas), 0);
--
