Hello Felipe.
On 09/12/2017 04:49 PM, Stefan Schmidt wrote:
Hello.
On 09/07/2017 07:24 AM, Felipe Magno de Almeida wrote:
felipealmeida pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=743f52a05ba3c5985d9660cec09a4fcc43c55900
commit 743f52a05ba3c5985d9660cec09a4fcc43c55900
Author: Felipe Magno de Almeida <fel...@expertisesolutions.com.br>
Date: Thu Sep 7 12:05:24 2017 +0900
efl: Make models 0-based index, not 1-based
And another bisect pointing here. Felipe, I would really appreciate if
you would test your commits more before pushing them. Its not the first
time I tell you and your team this.
This time the patch broke the eldbus test suite. Reverting it fixes the
problem for me. You can ignore the problem properties_get problem but
the rest comes from this commit.
971 92%: Checks: 65, Failures: 5, Errors: 0
972
tests/eldbus/eldbus_test_eldbus_model.c:255:F:eldbus_model_connection:children_slice_get:0:
Assertion 'first_child == child' failed: first_child == 0xfb99a 4c6,
child == 0x399a4c7
973
tests/eldbus/eldbus_test_eldbus_model.c:255:F:eldbus_model_object:children_slice_get:0:
Assertion 'first_child == child' failed: first_child == 0xfb99a4c6,
child == 0x399a4c7
974
tests/eldbus/eldbus_test_eldbus_model_proxy.c:40:F:eldbus_model_proxy:properties_get:0:
Assertion '0 == eina_array_count(properties)' failed: 0 == 0, eina_
array_count(properties) == 2
975
tests/eldbus/eldbus_test_eldbus_model.c:255:F:eldbus_model_proxy:children_slice_get:0:
Assertion 'first_child == child' failed: first_child == 0x3a18e020,
child == 0x4218e021
976
tests/eldbus/eldbus_test_eldbus_model.c:121:F:eldbus_test_fake_server_eldbus_model_proxy:children_slice_get:0:
Assertion '((void *)0) != accessor' failed: ((void *)0) == 0,
accessor == 0
977 FAIL tests/eldbus/eldbus_suite (exit status: 1)
You might have fixed the recent breakage with @own and cxx now but this
one week old report of mine is still true. If I get no reaction here I
might go ahead and simply remove your commit from above to fix this.
regards
Stefan Schmidt
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
