raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=dea4e5aa46f5dc0a5532b1ad47a654580a26e666
commit dea4e5aa46f5dc0a5532b1ad47a654580a26e666 Author: Carsten Haitzler (Rasterman) <[email protected]> Date: Thu Sep 28 13:39:35 2017 +0900 elm widget - fix possible null ptr access found by coverity _propagate_event_legacy checked event_flags ptr for null then just derefs it anyway... so check everywhere. fixes CID 1379920 --- src/lib/elementary/elm_widget.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/lib/elementary/elm_widget.c b/src/lib/elementary/elm_widget.c index 45c2864787..85788bd935 100644 --- a/src/lib/elementary/elm_widget.c +++ b/src/lib/elementary/elm_widget.c @@ -1109,8 +1109,11 @@ _propagate_event_legacy(Eo *parent, const Efl_Event *event, Eo *obj, Elm_Event_C if (ecd->func((void *)ecd->data, parent, obj, type, event_info.any) || (event_flags && ((*event_flags) & EVAS_EVENT_FLAG_ON_HOLD))) { - if (prev_flags != *event_flags) - efl_input_event_flags_set(event->info, *event_flags); + if (event_flags) + { + if (prev_flags != *event_flags) + efl_input_event_flags_set(event->info, *event_flags); + } return EINA_TRUE; } --
