stefan pushed a commit to branch eina-1.7.

commit 2a12fc81e1f6663d7df8c920de76a27dec8ce119
Author: Stefan Schmidt <[email protected]>
Date:   Tue Jun 11 11:12:27 2013 +0100

    eina_xattr: Backport memory leak fix.
    
    Backport of 6467f603955bdea591d2f9a5d0c8e058dbbc94a7 / svn rev 83791
    
    In the error case we freed the iterator but not the attribute.
---
 ChangeLog            | 4 ++++
 NEWS                 | 7 ++++++-
 src/lib/eina_xattr.c | 1 +
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 244e96c..9ce3976 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -418,3 +418,7 @@
 2013-04-04  Rafael Antognolli
 
         * 1.7.6 release
+
+2013-06-11  Stefan Schmidt
+
+        * Fix memory leak in eina_xattr_value_ls
diff --git a/NEWS b/NEWS
index 7ae84ca..3a30891 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,9 @@
-Eina 1.7.7
+Changes since Eina 1.7.7:
+-------------------------
+
+Fixes:
+    * Fix memory leak in eina_xattr_value_ls
+
 
 Changes since Eina 1.7.6:
 -------------------------
diff --git a/src/lib/eina_xattr.c b/src/lib/eina_xattr.c
index d4ed139..5315cac 100644
--- a/src/lib/eina_xattr.c
+++ b/src/lib/eina_xattr.c
@@ -306,6 +306,7 @@ eina_xattr_value_ls(const char *file)
    it->length = listxattr(file, it->xattr, length);
    if (it->length != length)
      {
+        free(it->attr);
         free(it);
        return NULL;
      }

-- 

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

Reply via email to