seoz pushed a commit to branch master.
commit 975f144b257ad739490b344c4fc9b91f30e01067
Author: Daniel Juyung Seo <[email protected]>
Date: Sat Jul 6 12:49:54 2013 +0900
elm_gengrid/genlist.c: removed logically dead code. NULL is already checked.
This fixes 'Logically dead code' warning which was spotted by coverity.
CID 1040038, 1040040, 1040036, 1040037.
---
src/lib/elm_gengrid.c | 4 ----
src/lib/elm_genlist.c | 4 ----
2 files changed, 8 deletions(-)
diff --git a/src/lib/elm_gengrid.c b/src/lib/elm_gengrid.c
index 7b61607..1cd7480 100644
--- a/src/lib/elm_gengrid.c
+++ b/src/lib/elm_gengrid.c
@@ -3993,9 +3993,7 @@ elm_gengrid_item_select_mode_set(Elm_Object_Item *item,
Elm_Object_Select_Mode mode)
{
Elm_Gen_Item *it = (Elm_Gen_Item *)item;
-
ELM_GENGRID_ITEM_CHECK_OR_RETURN(it);
- if (!it) return;
if (it->generation < GG_IT(it)->wsd->generation) return;
if (mode >= ELM_OBJECT_SELECT_MODE_MAX)
@@ -4012,10 +4010,8 @@ EAPI Elm_Object_Select_Mode
elm_gengrid_item_select_mode_get(const Elm_Object_Item *item)
{
Elm_Gen_Item *it = (Elm_Gen_Item *)item;
-
ELM_GENGRID_ITEM_CHECK_OR_RETURN(it, ELM_OBJECT_SELECT_MODE_MAX);
- if (!it) return ELM_OBJECT_SELECT_MODE_MAX;
return it->select_mode;
}
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index e9c5089..2112638 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -7308,7 +7308,6 @@ elm_genlist_item_select_mode_set(Elm_Object_Item *item,
Elm_Gen_Item *it = (Elm_Gen_Item *)item;
ELM_GENLIST_ITEM_CHECK_OR_RETURN(item);
- if (!it) return;
ELM_GENLIST_DATA_GET_FROM_ITEM(it, sd);
if (it->generation < sd->generation) return;
@@ -7340,11 +7339,8 @@ EAPI Elm_Object_Select_Mode
elm_genlist_item_select_mode_get(const Elm_Object_Item *item)
{
Elm_Gen_Item *it = (Elm_Gen_Item *)item;
-
ELM_GENLIST_ITEM_CHECK_OR_RETURN(item, ELM_OBJECT_SELECT_MODE_MAX);
- if (!it) return ELM_OBJECT_SELECT_MODE_MAX;
-
return it->select_mode;
}
--
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
