devilhorns pushed a commit to branch master.

commit 57924e5824b4f38d2cddf4321d1da35798ee423e
Author: Chris Michael <[email protected]>
Date:   Mon Jul 8 11:25:59 2013 +0100

    Fix memleak reported by Coverity: Close the descriptor returned by
    popen if we are going to error out.
    
    NB: Fixes Coverity CID1039184
    
    Signed-off-by: Chris Michael <[email protected]>
---
 src/lib/efreet/efreet_menu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/efreet/efreet_menu.c b/src/lib/efreet/efreet_menu.c
index 098f8c7..88559c2 100644
--- a/src/lib/efreet/efreet_menu.c
+++ b/src/lib/efreet/efreet_menu.c
@@ -462,6 +462,7 @@ efreet_menu_kde_legacy_init(void)
     if (!fgets(buf, sizeof(buf), f))
     {
         ERR("Error initializing KDE legacy information");
+        pclose(f);
         return 0;
     }
     s = buf;

-- 

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

Reply via email to