devilhorns pushed a commit to branch master.
commit 07013042052f126075005f845dbc61302ad0156a
Author: Chris Michael <[email protected]>
Date: Mon Jul 8 12:39:48 2013 +0100
Fix memleak reported by Coverity and replace some XFree calls with
just free.
NB: Fixes Coverity CID1039275
Signed-off-by: Chris Michael <[email protected]>
---
src/lib/ecore_x/xlib/ecore_x_dnd.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/lib/ecore_x/xlib/ecore_x_dnd.c
b/src/lib/ecore_x/xlib/ecore_x_dnd.c
index f120017..ca5217f 100644
--- a/src/lib/ecore_x/xlib/ecore_x_dnd.c
+++ b/src/lib/ecore_x/xlib/ecore_x_dnd.c
@@ -268,13 +268,16 @@ ecore_x_dnd_type_set(Ecore_X_Window win,
{
if (ecore_x_dnd_type_isset(win, type))
{
- XFree(old_data);
+ if (old_data) free(old_data);
return;
}
newset = calloc(num + 1, sizeof(Ecore_X_Atom));
if (!newset)
- return;
+ {
+ if (old_data) free(old_data);
+ return;
+ }
data = (unsigned char *)newset;
@@ -290,14 +293,14 @@ ecore_x_dnd_type_set(Ecore_X_Window win,
{
if (!ecore_x_dnd_type_isset(win, type))
{
- XFree(old_data);
+ if (old_data) free(old_data);
return;
}
newset = calloc(num - 1, sizeof(Ecore_X_Atom));
if (!newset)
{
- XFree(old_data);
+ if (old_data) free(old_data);
return;
}
--
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
