On Thu, Jan 31, 2013 at 8:11 AM, Arvind R <arvin...@gmail.com> wrote:
> hi,
>
> It appears that elm_video_is_playing_get() always returns false. This
> manifests itself in 2 ways:
>
> With elm_video instantiated, Key_Left and Key_Right work in seeking
> forward/backward.
> Other keys print not not-handled message except 'space' key - implying
> space key is handled.
> This is as it should be w.r.t _elm_video_smart_event() in elm_video.c.
> But 'space' key does not pause video - ever.
>
> When elm_player is instantiated with its smart_data member 'video' set
> to a video instance - I believe that this is what is meant by the
> 'linking' mentioned in the docs - the overlapped pause/play buttons
> don't toggle - it always believes the video is stopped and has to
> played.
>
The default widgets/player.edc has programs trigerred by "elm,player,..."
but elc_player.c emits "elm,button,..."

Also 'stop' changes play-state - not taken care of in player.edc

The player.edc has a slider and buttons in two rows - taking up
precious vertical space - these days aspects are more often 16:9

Foll. is a patch for player.edc. The patch changes the player to button
and lays out the widgets in a single row without squashing.

Please, does this list prefer patches as I am sending or will accept a
tar.gz attachment?

>
> Arvind
---

diff -uprN a/data/themes/widgets/player.edc b/data/themes/widgets/player.edc
--- a/data/themes/widgets/player.edc    2012-07-25 16:41:51.000000000 +0530
+++ b/data/themes/widgets/player.edc    2013-01-31 15:55:29.000000000 +0530
@@ -4,28 +4,18 @@ group {
    min: 20 10;

    parts {
-      part { name: "media_player/slider"; type: SWALLOW;
-         description { state: "default" 0.0;
-            fixed: 0 1;
-            rel1.offset: 2 2;
-            rel2.offset: 2 -3;
-            rel2.relative: 1.0 0.0;
-            align: 0.5 0.0;
-         }
-      }
       part { name: "media_player/rewind"; type: SWALLOW;
          description { state: "default" 0.0;
             fixed: 1 0;
             min: BSZ BSZ;
-            align: 0.0 1.0;
+            align: 0.0 0.5;
             rel1 {
-               to_y: "media_player/slider";
-               offset: 2 2;
-               relative: 0.0 1.0;
+               relative: 0.0 0.0;
+               offset: 10 2;
             }
             rel2 {
-               relative: 0.0 1.0;
-               offset: 2 -3;
+               relative: 0.0 0.95;
+               offset: 45 -1;
             }
          }
       }
@@ -35,12 +25,12 @@ group {
             min: BSZ BSZ;
             align: 0.0 1.0;
             rel1 { to: "media_player/rewind";
-               offset: 2 0;
                relative: 1.0 0.0;
+               offset: 8 0;
             }
             rel2 { to: "media_player/rewind";
-               offset: 2 -1;
                relative: 1.0 1.0;
+               offset: 43 -1;
             }
          }
       }
@@ -50,12 +40,12 @@ group {
             min: BSZ BSZ;
             align: 0.0 1.0;
             rel1 { to: "media_player/prev";
-               offset: 2 0;
                relative: 1.0 0.0;
+               offset: 6 0;
             }
             rel2 { to: "media_player/prev";
-               offset: 2 -1;
                relative: 1.0 1.0;
+               offset: 40 -1;
             }
          }
          description { state: "hidden" 0.0;
@@ -80,12 +70,12 @@ group {
             min: BSZ BSZ;
             align: 0.0 1.0;
             rel1 { to: "media_player/play";
-               offset: 2 0;
                relative: 1.0 0.0;
+               offset: 5 0;
             }
             rel2 { to: "media_player/play";
-               offset: 2 -1;
                relative: 1.0 1.0;
+               offset: 40 -1;
             }
          }
          description { state: "hidden" 0.0;
@@ -99,11 +89,11 @@ group {
             min: BSZ BSZ;
             align: 0.0 1.0;
             rel1 { to: "media_player/info";
-               offset: 2 0;
+               offset: 5 0;
                relative: 1.0 0.0;
             }
             rel2 { to: "media_player/info";
-               offset: 2 -1;
+               offset: 35 -1;
                relative: 1.0 1.0;
             }
          }
@@ -114,24 +104,41 @@ group {
             min: BSZ BSZ;
             align: 0.0 1.0;
             rel1 { to: "media_player/stop";
-               offset: 2 0;
+               offset: 6 0;
                relative: 1.0 0.0;
             }
             rel2 { to: "media_player/stop";
-               offset: 2 -1;
+               offset: 40 -1;
                relative: 1.0 1.0;
             }
          }
       }
       part { name: "media_player/forward"; type: SWALLOW;
          description { state: "default" 0.0;
+            fixed: 1 1;
             min: BSZ BSZ;
             align: 0.0 1.0;
             rel1 { to: "media_player/next";
-               offset: 2 0;
+               offset: 6 0;
                relative: 1.0 0.0;
             }
-            rel2.offset: -3 -3;
+            rel2 { to: "media_player/next";
+               offset: 40 -1;
+               relative: 1.0 1.0;
+            }
+         }
+      }
+      part { name: "media_player/slider"; type: SWALLOW;
+         description { state: "default" 0.0;
+            fixed: 0 1;
+                       align: 0.0 0.0;
+                       rel1 {
+                               to_x: "media_player/forward";
+               relative: 1.0 0.0;
+               offset: 12 0;
+                       }
+            rel2.relative: 0.995 0.99;
+            rel2.offset: 0 -BSZ-5;
          }
       }
    }
@@ -142,12 +149,17 @@ group {
          after: "pause/0";
       }
       program {
-         signal: "elm,player,play";
+         signal: "elm,button,play";
          source: "elm";
          after: "play/0";
       }
       program {
-         signal: "elm,player,pause";
+         signal: "elm,button,pause";
+         source: "elm";
+         after: "pause/0";
+      }
+      program {
+         signal: "elm,button,stop";
          source: "elm";
          after: "pause/0";
       }

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
enlightenment-users mailing list
enlightenment-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-users

Reply via email to