On 9/23/21 9:00 AM, Miro Hrončok wrote:
On 23. 09. 21 5:41, Orion Poplawski wrote:
-Requires: %{name}%{?_isa} = %{version}-%{release}
+Requires: utf8proc%{?_isa} >= %{version}-%{release}

I'd assume that anybody (even you) might need to rebuild this package in EPEL at any time for various reasons and %{release} might be larger than the RHEL package release. This >= requireement will break.

Also, if the RHEL version gets updated to e.g. 2.1.2 (unlikely, but not impossible), the EPEL devel package will still be able to be installed, which is probably undesired.

If you don't need to follow RHEL's release number that much, I suggest to do:

Requires: utf8proc%{?_isa} = %{version}

And if you do, I suggest to do:

%global rhel_release 5
Requires: (utf8proc%{?_isa} = %{version} with utf8proc%{?_isa} >= %{version}-%{rhel_release})

You could even incorporate the RHEL's release to the EPEL's release, if you feel like it:

%global rhel_release 5
%global base_release 1

Release:  %{rhel_release}.%{base_release}%{?dist}


Side note: I also suggest to BuildRequire the runtime requirement (sans %{?_isa}) and track the package in Koschei. That way, you can get a notification if the requirement was broken by an RHEL update and the EPEL package needs to be updated as well.


Thanks, good ideas!

--
Orion Poplawski
he/him/his - surely the least important thing about me
Manager of NWRA Technical Systems          720-772-5637
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       or...@nwra.com
Boulder, CO 80301                 https://www.nwra.com/

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
epel-devel mailing list -- epel-devel@lists.fedoraproject.org
To unsubscribe send an email to epel-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to