At this point the logic to bypass the loading of the config.ini in the fwk would only apply when we are in shared install. I will push that later today. We can look into doing a systematic bypass later.
Thanks for reverting the change to the launcher. From: equinox-dev-boun...@eclipse.org [mailto:equinox-dev-boun...@eclipse.org] On Behalf Of Thomas Watson Sent: January-25-13 10:36 AM To: Equinox development mailing list Subject: Re: [equinox-dev] Does the fwk load the config.ini Yes, and we should continue to do so. If I understand you correctly, you are suggesting we avoid re-reading the config.ini in the case where the launcher already did it. I think that is a good thing and I always thought it was a bit of waste that we re-read a file that the launcher already loaded for us. As a side note, lets hold of on incrementing version numbers of the launchers until we get past M5 since we need to update all the host version ranges of the launcher fragments when we do that (https://bugs.eclipse.org/bugs/show_bug.cgi?id=399037) Tom [Inactive hide details for Pascal Rapicault ---01/25/2013 09:15:16 AM---Aren’t we reading it for the case where the fwk is star]Pascal Rapicault ---01/25/2013 09:15:16 AM---Aren’t we reading it for the case where the fwk is started w/o using the launcher? From: equinox-dev From: Pascal Rapicault <pascal.rapica...@ericsson.com<mailto:pascal.rapica...@ericsson.com>> To: Equinox development mailing list <equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org>>, Date: 01/25/2013 09:15 AM Subject: Re: [equinox-dev] Does the fwk load the config.ini Sent by: equinox-dev-boun...@eclipse.org<mailto:equinox-dev-boun...@eclipse.org> ________________________________ Aren’t we reading it for the case where the fwk is started w/o using the launcher? From: equinox-dev-boun...@eclipse.org<mailto:equinox-dev-boun...@eclipse.org> [mailto:equinox-dev-boun...@eclipse.org] On Behalf Of Thomas Watson Sent: January-25-13 9:03 AM To: Equinox development mailing list Subject: Re: [equinox-dev] Does the fwk load the config.ini Sounds reasonable to do that check. I always thought it was a bit silly to re-read the config.ini in the EclipseStarter if the launcher already did it! Tom [Inactive hide details for Pascal Rapicault ---01/24/2013 08:19:04 PM---I’ve decided to stop reading the user configuration whe]Pascal Rapicault ---01/24/2013 08:19:04 PM---I’ve decided to stop reading the user configuration when the base has changed to minimize the risk o From: Pascal Rapicault <pascal.rapica...@ericsson.com<mailto:pascal.rapica...@ericsson.com>> To: Equinox development mailing list <equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org>>, Date: 01/24/2013 08:19 PM Subject: Re: [equinox-dev] Does the fwk load the config.ini Sent by: equinox-dev-boun...@eclipse.org<mailto:equinox-dev-boun...@eclipse.org> ________________________________ I’ve decided to stop reading the user configuration when the base has changed to minimize the risk of having erroneous information in the config.ini (bundles that are no longer available, config entries no longer relevant) that could harm the startup process. A similar logic has been implemented in the simpleconfigurator and will be merged in master by Sunday night. The code is currently available in a branch called prapicau/sharedInstall-part1. The code that needs to be added to EclipseStarter is as simple as an if statement accessing a system property set by the launcher. From: equinox-dev-boun...@eclipse.org<mailto:equinox-dev-boun...@eclipse.org> [mailto:equinox-dev-boun...@eclipse.org] On Behalf Of Thomas Watson Sent: January-24-13 5:13 PM To: Equinox development mailing list Subject: Re: [equinox-dev] Does the fwk load the config.ini Out of curiosity, why do you need to prevent the reading of the user's configuration if the base has changed? I guess you released some changes to the launcher to do this same kind of logic. You just now need to apply that logic in EclipseStarter so it does not clobber the changes you did to the launcher? Tom [Inactive hide details for Pascal Rapicault ---01/24/2013 03:54:51 PM---Your recollection is correct. Today the launcher reads t]Pascal Rapicault ---01/24/2013 03:54:51 PM---Your recollection is correct. Today the launcher reads the user configuration and then merges the ba From: Pascal Rapicault <pascal.rapica...@ericsson.com<mailto:pascal.rapica...@ericsson.com>> To: Equinox development mailing list <equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org>>, Date: 01/24/2013 03:54 PM Subject: Re: [equinox-dev] Does the fwk load the config.ini Sent by: equinox-dev-boun...@eclipse.org<mailto:equinox-dev-boun...@eclipse.org> ________________________________ Your recollection is correct. Today the launcher reads the user configuration and then merges the based configuration, whereas the EclipseStarter only reads the user configuration. The reason I’m looking into this is because I need to change the EclipseStarter logic to bypass the reading of the config.ini when the base has changed (which I can do easily since the heavy lifting is done in the launcher) but I wanted to be sure that not loading any properties in the FrameworkProperties would not be an issue. From: equinox-dev-boun...@eclipse.org<mailto:equinox-dev-boun...@eclipse.org> [mailto:equinox-dev-boun...@eclipse.org] On Behalf Of Thomas Watson Sent: January-24-13 4:42 PM To: Equinox development mailing list Subject: Re: [equinox-dev] Does the fwk load the config.ini Now that you mention that I am not sure what is expected to happen with the shared configuration and the config.ini files. I guess it should read the users configuration and then merge in the parent configuration, or is it the other way around? If I recall correctly the launcher does do cascade reading of the shared configurations, but I am unsure if the user's configuration overrides the parents or not. At any rate, for shared configurations I think we depend on the launcher to do the merging of the cascaded configurations. Tom [Inactive hide details for Pascal Rapicault ---01/24/2013 03:35:04 PM---Thanks for the pointer Tom. I've looked at the code and]Pascal Rapicault ---01/24/2013 03:35:04 PM---Thanks for the pointer Tom. I've looked at the code and I'm a bit surprise to see that this code is From: Pascal Rapicault <pascal.rapica...@ericsson.com<mailto:pascal.rapica...@ericsson.com>> To: Equinox development mailing list <equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org>>, Date: 01/24/2013 03:35 PM Subject: Re: [equinox-dev] Does the fwk load the config.ini Sent by: equinox-dev-boun...@eclipse.org<mailto:equinox-dev-boun...@eclipse.org> ________________________________ Thanks for the pointer Tom. I’ve looked at the code and I’m a bit surprise to see that this code is not handling shared configuration. Is that expected or am I missing something obvious? Thx Pascal From: equinox-dev-boun...@eclipse.org<mailto:equinox-dev-boun...@eclipse.org> [mailto:equinox-dev-boun...@eclipse.org] On Behalf Of Thomas Watson Sent: January-24-13 3:18 PM To: Equinox development mailing list Subject: Re: [equinox-dev] Does the fwk load the config.ini If the framework is launched with EclipseStarter (which the launcher uses) then yes it does [1]. Tom [1] see org.eclipse.core.runtime.adaptor.EclipseStarter.loadConfigurationInfo() [Inactive hide details for Pascal Rapicault ---01/24/2013 12:25:23 PM---When running eclipse, does the framework also load the c]Pascal Rapicault ---01/24/2013 12:25:23 PM---When running eclipse, does the framework also load the config.ini or does always leave that to the l From: Pascal Rapicault <pascal.rapica...@ericsson.com<mailto:pascal.rapica...@ericsson.com>> To: "equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org>" <equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org>>, Date: 01/24/2013 12:25 PM Subject: [equinox-dev] Does the fwk load the config.ini Sent by: equinox-dev-boun...@eclipse.org<mailto:equinox-dev-boun...@eclipse.org> ________________________________ When running eclipse, does the framework also load the config.ini or does always leave that to the launcher? thx Pascal _______________________________________________ equinox-dev mailing list equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org> https://dev.eclipse.org/mailman/listinfo/equinox-dev_______________________________________________ equinox-dev mailing list equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org> https://dev.eclipse.org/mailman/listinfo/equinox-dev_______________________________________________ equinox-dev mailing list equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org> https://dev.eclipse.org/mailman/listinfo/equinox-dev_______________________________________________ equinox-dev mailing list equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org> https://dev.eclipse.org/mailman/listinfo/equinox-dev_______________________________________________ equinox-dev mailing list equinox-dev@eclipse.org<mailto:equinox-dev@eclipse.org> https://dev.eclipse.org/mailman/listinfo/equinox-dev
<<inline: image001.gif>>
_______________________________________________ equinox-dev mailing list equinox-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/equinox-dev
