I am happy to be able to contribute. I installed 1.3RC1 on
http://trip.autosys.us and found that a change in
lib/wparts-N/wpart_include.erl causes breakage of stylesheet
includes, e.g. using
<wpart:include file="templates/trip/style.css" format="html" />
causes style information to show up as plain text using 1.3RC1.
Using 1.2.1 and the style information would affect the page
style as desired.
Here is the change ...
< is from wparts-1.2.1
> is from wparts-1.3
39c38,39
< wpartlib:format(#xmlText{value = Tpl}, E); %% STYLIN'
---
> #xmlText{value = wpartlib:format(Tpl, E)}; %% PLAIN TEXT
I did not make a patch because I do not know why the change was
made.
Is there some other recommended way of including a stylesheet ?
(for now, I have changed my local code so the includes work)
~M
On Tue, May 05, 2009 at 11:48:46AM +0100, Michal Ptaszek wrote:
> Hello Michael!
>
> Thank you very much for your patches - they will be included
> in the 1.3 final release.
>
> ----- "Michael McDaniel" <[email protected]> wrote:
>
> > Thank you again for Erlang Web.
> >
> >
> > Attached are some patches to convert the remaining deprecated
> > regexp library funs to re library funs.
> >
> >
> > I hope you have a good regression test suite. I am not
> > running anything that exercises the changes very well.
> > Intention, of course, is to not break anything ! Please
> > let me know in either case.
> >
> >
> > The patches were made by
> >
> > $ cp filename.erl filename.erl.orig
> >
> > $ emacs filename.erl
> >
> > $ diff -u filename.erl.orig filename.erl > filename.patch
> >
> >
> > (on Ubuntu GNU/Linux 8.04)
> > $ uname -a
> > Linux delora 2.6.24-24-386 #1 Wed Apr 15 15:13:41 UTC 2009 i686
> > GNU/Linux
> >
> >
> > The attached tgz file should be untarred from your erlang-web
> > directory and also contains the *.orig files. Of course, after
> > patching and changing back to erlang-web top directory, rerun
> >
> > $ bin/compile.erl
> >
> >
> > I have not yet tested out the new version and new features.
> > The quick start 'Welcome to Erlang Web' works, though it
> > probably does not exercise the changes I made.
> >
> >
> > ~Michael
> >
> >
> >
> >
> > --
> > Michael McDaniel
> > Portland, Oregon, USA
> > http://autosys.us
>
> Best regards,
> --
> Michal Ptaszek
> www.erlang-consulting.com
------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image
processing features enabled. http://p.sf.net/sfu/kodak-com
_______________________________________________
Erlangweb-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/erlangweb-users
http://www.erlang-web.org/