+1.

I'd like to see this fix included, please.

-jw

On Dec 4, 2008, at 2:29 AM, Michael Mullis wrote:

>
> Hi.
> erlydb_mnesia:get_metadata current code throws an error.
> Please review and apply the following patch.
> thanks, michael.
> ======
>
> diff --git a/src/erlydb/erlydb_mnesia.erl b/src/erlydb/
> erlydb_mnesia.erl
> index bd7a136..54a66bb 100644
> --- a/src/erlydb/erlydb_mnesia.erl
> +++ b/src/erlydb/erlydb_mnesia.erl
> @@ -184,11 +184,10 @@ start(_Options) ->
> get_metadata(_Options) ->
>       % NOTE Integration with mnesia_rdbms would be interesting...
>     Tables = mnesia:system_info(tables) -- [schema],
> -    Tree = lists:foldl(
> -                     fun(Table, TablesTree) ->
> -             gb_trees:enter(Table, get_metadata(Table, table_fields
> (Table)), TablesTree)
> -             end, gb_trees:empty(), Tables),
> -     {ok, Tree}.
> +    lists:foldl(
> +      fun(Table, TablesTree) ->
> +          gb_trees:enter(Table, get_metadata(Table, table_fields
> (Table)), TablesTree)
> +      end, gb_trees:empty(), Tables).
>
> get_metadata(Table, Fields) when is_list(Fields) ->
>     [get_metadata(Table, Field) || Field <- Fields];
> @@ -356,6 +355,7 @@ select(Modifier, Fields, Tables, WhereExpr,
> Extras, Options, QHDesc) ->
>           end,
>       QLC1 = QLC ++ " || " ++ comma(Desc#qhdesc.generators ++ lists:reverse
> (Desc#qhdesc.filters)) ++ "].",
>     ?L(["About to execute QLC: ", QLC1]),
> +    ?L(["With bindings : ", Desc#qhdesc.bindings]),
>     {atomic, Results} = transaction(
>       fun() ->
>             QHOptions = Desc#qhdesc.options,
>
> >


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"erlyweb" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/erlyweb?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to