On Thu, Mar 16, 2017 at 7:04 PM, Karl Cheng <qantas94he...@gmail.com> wrote:
> On 17 March 2017 at 08:03, Ben Newman <benja...@cs.stanford.edu> wrote:
> > Just to check my understanding, would
> >
> > Boolean.parseBoolean = function (value) {
> > return !! (value && JSON.parse(String(value)));
> > };
> >
> > be a reasonable polyfill for your proposed function?
>
> Not quite -- that would throw for strings that are not valid JSON, e.g.:
>
> ```
> Boolean.parseBoolean('{dddddd]');
> ```
>
> It'd probably be more like:
>
> ```
> Boolean.parseBoolean = function (val) {
> if (val === 'false') return false;
> return !!val;
> };
> ```
>
Looks good either (probably worth making case-insensitive).
Dmitry
_______________________________________________
es-discuss mailing list
es-discuss@mozilla.org
https://mail.mozilla.org/listinfo/es-discuss
