I added Anne's comments to the Jira item. D.
On Fri, Oct 2, 2009 at 11:30 AM, Anne Kathrine Petterøe <[email protected]> wrote: > Just did a bit of testing, and there seems to be a couple of issues. > > 1. I can no longer follow any users from the "List users" page. The link to > the profile pages are broken. > I have to enter the profile URL (like: > http://esmecloudserverapache.dickhirsch.staxapps.net/user/esjewett) to > access the user's profile page. > 2. Under "Last message" my reply to @vdichev shows up on both my user as > well as for @vdichev. > > /Anne > > > On 2. okt. 2009, at 10.57, Richard Hirsch wrote: > >> I meant "Would you like to try and create a new patch based" >> >> On Fri, Oct 2, 2009 at 10:57 AM, Richard Hirsch <[email protected]> >> wrote: >>> >>> Committed the code from your patch and deployed it on stax. >>> >>> Would you like to try my a new patch based on Vassil's suggestions and >>> my comments on the JIRA item? >>> >>> D. >>> >>> On Thu, Oct 1, 2009 at 6:46 PM, Richard Hirsch <[email protected]> >>> wrote: >>>> >>>> @Dave - I'll do a test deployment tomorrow with the files from the >>>> Jira item. Then, I'll probably do a commit just to keep things >>>> rolling. Afterwards, Vassil and you can sit down and figure out how to >>>> improve the code. >>>> >>>> P.S. I like the fact that you are getting rid of the code that is >>>> commented-out. You are right - that stuff really doesn't belong in the >>>> code base - that is why we have SVN. >>>> >>>> D. >>>> >>>> On Thu, Oct 1, 2009 at 11:42 AM, Richard Hirsch <[email protected]> >>>> wrote: >>>>> >>>>> @Dave: do you want me to make a commit/deployment based on the first >>>>> version of code or do you want to make a new version based on vassil's >>>>> suggestions and then I'll make a commit? >>>>> >>>>> Or both :-> >>>>> >>>>> D. >>>>> >>>>> On Thu, Oct 1, 2009 at 11:14 AM, Vassil Dichev <[email protected]> >>>>> wrote: >>>>>> >>>>>> Yes, sorry, I'm being myopic today. In that case, as a matter of >>>>>> personal preference, I don't very much like using _1, _2, etc. for >>>>>> tuples. Extracting values to meaningful variable names seems more >>>>>> readable. For instance, on line 61, instead of >>>>>> >>>>>> val msg = lastMessage(u.id) >>>>>> >>>>>> you could do >>>>>> >>>>>> val (m, when) = lastMessage(u.id) >>>>>> >>>>>> and lines 77-78, instead of >>>>>> >>>>>> case msgs => { >>>>>> val msg = msgs(0)._1 >>>>>> >>>>>> I would prefer >>>>>> >>>>>> case (msg, _) :: _ => { >>>>>> >>>>>> Does that read better? >>>>>> >>>>>> Vassil >>>>>> >>>>>> >>>>>> On Thu, Oct 1, 2009 at 12:01 PM, Dave Briccetti <[email protected]> >>>>>> wrote: >>>>>>> >>>>>>> No, the UserView is no longer used for this page. I just deleted part >>>>>>> of it. >>>>>>> I didn’t write anything. The new Scala code is in UserMgr. The video >>>>>>> explains, and you could probably fast-forward or skip through it. >>>>>>> >>>>>>> On Oct 1, 2009, at 1:49 AM, Vassil Dichev wrote: >>>>>>> >>>>>>>> Apart from the fact that xml is coded in the UserView, it looks very >>>>>>>> good. I especially like the pattern to destructure a tuple into vals >>>>>>>> using case: >>>>>>>> >>>>>>>> map{ >>>>>>>> case (m, idx) =>... >>>>>>>> >>>>>>>> Quite readable. >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Oct 1, 2009 at 11:16 AM, Dave Briccetti >>>>>>>> <[email protected]> >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Patch file and new files (see video for explanation), for review: >>>>>>>>> >>>>>>>>> >>>>>>>>> https://issues.apache.org/jira/secure/attachment/12420990/esme-86.zip >>>>>>>>> >>>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> > >
