This turned out to be easy, as jwebunit is only used in the "browse" method of the JettyServer, and no one uses the "browse" method, so I could just delete it.
I've committed the changes to trunk. We should now be jwebunit-free :-) Ethan On Tue, Feb 16, 2010 at 6:29 PM, Ethan Jewett <[email protected]> wrote: > Ok, I'm playing email-amateur today. Please respond to this email (to > just the ESME list) instead of the detailed email I mistakenly sent > out to the general list. > > Just to re-outline what I mistakenly sent to the general list: > > I'll try to spend some time looking at it. On the surface, it looks > like it's imported into my API2 tests but is not really used. I'll try > removing it from the tests in general, not just API2. > > It looks like it really is used in the JettySetup.scala file. I can > try removing it from there as well, but I'm less optimistic that tests > will still run. Who originally created this setup? David? > > Thanks, > Ethan > > On Tue, Feb 16, 2010 at 6:26 PM, Ethan Jewett <[email protected]> wrote: >> Thanks Joe and Bertrand. Point taken. Better to be safe and respectful >> than sorry. >> >> I'll try to spend some time looking at it. On the surface, it looks >> like it's imported into my API2 tests but is not really used. I'll try >> removing it from the tests in general, not just API2. >> >> It looks like it really is used in the JettySetup.scala file. I can >> try removing it from there as well, but I'm less optimistic that tests >> will still run. Who originally created this setup? David? >> >> Ethan >> >> On Tue, Feb 16, 2010 at 5:17 PM, Bertrand Delacretaz >> <[email protected]> wrote: >>> On Tue, Feb 16, 2010 at 6:11 PM, Joe Schaefer <[email protected]> >>> wrote: >>>> ----- Original Message ---- >>>> >>>>> From: Bertrand Delacretaz <[email protected]> >>>>> ...Unfortunately I'm -1 on the release, I have a few issues including a >>>>> GPL dependency. >>>>> >>>>> 1) jwebunit dependency is GPL >>>>> The server module depends on >>>>> >>>>> net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test >>>>> >>>>> which according to http://jwebunit.sourceforge.net/license.html is GPL. >>>> >>>> Well isn't jwebunit a test framework, in which case, (and assuming there >>>> are no dependencies on it in the production-ready codebase of esme) do >>>> we really care that it's GPL or not? ... >>> >>> I see your point, one could argue that people don't need jwebunit to >>> *run* ESME, they only need it to run the tests when building it. >>> >>> Still, the code that is distributed contains imports of jwebunit, so I >>> think that's stretching the concept too far. >>> >>>>... (Note an exception to the (L)GPL >>>> policy was recently granted for build dependencies, so I think it's might >>>> be possible to extend that to test deps.)... >>> >>> Might be possible, but getting rid of that jwwebunit dependency would >>> be much cleaner IMO. I haven't checked how much work that represents, >>> but according to http://jwebunit.sourceforge.net/ that's "just" a >>> wrapper on top of HtmlUnit which has an Apache license, so using >>> HtmlUnit instead might not be too hard. >>> >>> -Bertrand >>> >> >
