[
https://issues.apache.org/jira/browse/ETCH-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663779#action_12663779
]
scott comer commented on ETCH-25:
---------------------------------
here is the patch:
Index:
binding-csharp/runtime/src/main/csharp/Etch/Transport/DefaultDeliveryService.cs
===================================================================
---
binding-csharp/runtime/src/main/csharp/Etch/Transport/DefaultDeliveryService.cs
(revision 732348)
+++
binding-csharp/runtime/src/main/csharp/Etch/Transport/DefaultDeliveryService.cs
(working copy)
@@ -192,7 +192,7 @@
}
finally
{
- mb.CloseDelivery();
+ mb.CloseRead();
}
}
Index:
binding-java/runtime/src/main/java/etch/bindings/java/transport/DefaultDeliveryService.java
===================================================================
---
binding-java/runtime/src/main/java/etch/bindings/java/transport/DefaultDeliveryService.java
(revision 732348)
+++
binding-java/runtime/src/main/java/etch/bindings/java/transport/DefaultDeliveryService.java
(working copy)
@@ -211,7 +211,7 @@
}
finally
{
- mb.closeDelivery();
+ mb.closeRead();
}
}
}
> DefaultDeliveryService ends call with mb.CloseDelivery() and it should end it
> with mb.CloseRead()
> -------------------------------------------------------------------------------------------------
>
> Key: ETCH-25
> URL: https://issues.apache.org/jira/browse/ETCH-25
> Project: Etch
> Issue Type: Bug
> Components: csharp-binding, java-binding
> Affects Versions: 1.0.0, 1.0.1
> Reporter: scott comer
>
> when done reading the mailbox, the right method to call is CloseRead().
> somehow the code actually calls CloseDelivery(), a method used to shutdown
> the writing side of the mailbox. CloseRead() calls CloseDelivery() first off,
> but then takes the additional steps of redelivering any messages left in the
> mailbox.
> The distinction is rather fine, and this bug was found by reading the source
> code. There are certain ways you could exercise this bug, but it would be
> very rare and not have any real impact. So, it isn't an emergency to fix it,
> but it is also a relatively benign fix. I've already made the change in my
> tree and tested it. The patch is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
