agreed.
James Dixson wrote:
I have no objections, but I think as part of the change we should try to
document the internal steps for constructing transports.
Changes like this impede the rate at which we integrate other languages,
e.g. Python. Mostly because I have to re-learn the flow and decide how
impactful the change is to the binding implementation.
--
James
On 2/9/09 10:35 AM, "Scott Comer (sccomer)" <[email protected]> wrote:
anyone object to this going into etch release 1.1? i've attached a patch
for java and comment describing the issue a bit more fully.
it is mainly an issue of who does plumbing and when. this makes the
listener stack construction process more like the
transport stack construction. there is little risk but some code changes
would be needed to existing listeners as the
top level object changed from Transport<ServerFactory> to just
ServerFactory (as that became a Transport itself).
scott out
scott comer (JIRA) wrote:
Listener stack is build 1/2 upside down and strange inhibiting name service
and other transport filters
-----------------------------------------------------------------------------
--------------------------
Key: ETCH-59
URL: https://issues.apache.org/jira/browse/ETCH-59
Project: Etch
Issue Type: Improvement
Components: csharp-binding, java-binding
Affects Versions: 1.0.1, 1.0.0, 1.0.2
Reporter: scott comer
Assignee: scott comer
Priority: Minor
Fix For: 1.1
when a service creates a listener, using BlahHelper.newListener(), the
listener stack is built top down for a bit and then bottom up and glued
together. this is done in such a way that creating a listener filter is
inhibited. this is needed for the name server's etch: listener scheme.
