On Wed, May 01, 2002 at 01:04:29AM +0200, Joerg Mayer wrote:
> 85 unused parameter warnings gone,
I've checked in most of those, with the exception of:
some where the warning pointed out code that needed cleanups or
fixes, in which case I put in the fix instead;
some of the SMB ones, where I want to see whether the warning is
pointing out a problem;
the NCP stuff - Gilbert, is any of that stuff going to be used
with the new NCP stuff, so that the arguments are no longer
unused?
> 499 left.
I've nailed a few more of them.
> Guy, please consider turning on
> all warnings so people working on dissectors see what's left to do (examples
> that come to mind are the dcerpc and apf stuff). In case we are not done
> by the time the next release is due we can still turn those warnings off
> again.
Well, there's still a fair bit of noise - the biggest offenders at this
point are:
the generated dissectors for some GIOP protocols - fixing that
"right", may be hard, as the generator might not know whether
the variable in the boilerplate it generates will be used, so it
might just have to flag *variables* with _U_ (it's generated
code, so that sort of ugliness doesn't bother me all that much);
the GIOP dissector itself;
the GTP dissector;
the ICQ dissector;
the ISIS dissector;
the ISUP dissector;
the DCE RPC stuff, and NT services built atop it;
and some others, not quite as noisy, are:
the AFS stuff;
the IGMP dissector;
and some with only a few complaints.
I'm inclined to wait a few days to see if this message prompts people to
clean up the biggest offenders, and then turn the warnings up if they're
not cleaned up in a few days.
