On Thu, 27 Nov 2003, Guy Harris wrote:

> On Thu, Nov 27, 2003 at 12:19:03AM -0800, Richard Sharpe wrote:
> > I just noticed the following in proto_draw.c:packet_hex_print:
> > 
> >   OBJECT_SET_DATA(bv, E_BYTE_VIEW_START_KEY, GINT_TO_POINTER(bend));
> >   OBJECT_SET_DATA(bv, E_BYTE_VIEW_END_KEY, GINT_TO_POINTER(bstart));
> > 
> > Why do we store bend under E_BYTE_VIEW_START_KEY and bstart under 
> > E_BYTE_VIEW_END_KEY?
> 
> Good question.
> 
> Why does Ethereal appear to correctly redisplay the highlighted section
> if you change the highlighting mode, given that the start and end values
> are reversed?

I think that the code that retrieves the info knows about this reversal. 
However, it looks wrong.

Regards
-----
Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org, 
sharpe[at]ethereal.com, http://www.richardsharpe.com

Reply via email to