----- Original Message ----- From: "Ulf Lamping" Sent: Tuesday, September 10, 2002 12:11 AM Subject: [Ethereal-dev] usability extensions: 2nd "recent" patch
> Hi List, hi Ronnie! > > Please find attached the second version of the "recent user's file" patch. > > If you don't find any reasonable bugs in the code, could you please check it in, > as diffing the code is a bit complicated for me now (I have to edit the diff file > a lot by hand), as I have made more recent GUI changes in my sourcetree, > which I will send in the future, if they are finished. > > I have no problem, applying changes to this again, to improve the "recent user file" code, > if someone suggesting improvements or moving parts of the source to a different > place (where it is more suitable). Seriously, there are two thing I dont think I like with the patch. It does mess with file.c which I am not conviced is nessecary. Second, it is a very complex implementation of what I think is a simple concept. (see my previous mail with a proposal for a very naive but simple design) Lets give it a few days to see if there are any other comments and if not it goes in on Friday. Ok? === Would you have time and interest in looking at improving the display filter dialog you get by pressing the "Filter:" button? That one is a real nightmare and i still have problems whenever i try to demonstrate it because it just doesnt make sense. This job would consist of three parts: * come up with a completely new but working GUI design that perhaps people actually understands how it works. I guess your hands are free, it cant really get worse. perhaps create a mockup design to discuss on the dev list? * I would really like disdplay filters to be stored each in their own file, one filter per file. This would make it MUCH easier to transfer filters to other users. It would allow a central repository of useful filters, something we could have on the webpage: an annotated list of useful displayfilters? What to do with people already having a milion filters in the current single-file for all filters implementation? Perhaps just a warning if the single-file thing is detected with pointers to a shellscript or something that could convert it to one-file-per-filter? I am totally for this change. imho display filters are extremely powerful and the most important feature of them all in ethereal. it is a shame that the gui for newbies for displayfilters is so crappy. if you make the display filter dialog work you will be a hero.
