Hi, I actually looked at the dissect_atm_nsap routine when writing the code but I wasn't shure the syntax were exactly the same and I wanted to test *my* code first before involving other dissectors which I can't do any tests for.
NSAP and X.213 is mentioned in a bunch of dissectors but most seem to do no parsing, perhaps they would with an avalable routine ? What would be the best way to go with this ? - expand the parsing/leave it as it is - Create packet-x213.c ( x213.c ) - Create packet-nsap.c ( nsap.c ) - leave the routine in packet-isup - Should e164,x121,iso dcc f.69 etc have their own files if parsing is to be expanded. As for E.164 parsing I'm not shure how interesting it realy is but pointing out the country and in some cases the next level ( region/international network/.. )may have some merrit. Should this kind of stuff be put in e164.c ( like the t35.c file ) or in one of the above mentioned files, as the E.164 number is transported in many different encodings, different service routines may have to be made. I'm leaning towards creating files packet-x213.c or x213.c, e164.c and moving the existing NSAP and E.164 dissecting code there to be expanded as seen fit. Best regards Anders -----Original Message----- From: Guy Harris [mailto:[EMAIL PROTECTED] Sent: den 7 oktober 2003 19:49 To: Anders Broman (TN/EAB) Cc: [EMAIL PROTECTED] Subject: Re: [Ethereal-dev] Patch to Packet-isup On Tue, Oct 07, 2003 at 05:57:04PM +0200, Anders Broman (TN/EAB) wrote: > Changed some variable names to conform to abriviations used in the > specs, added dissection of some more BAT ASE elements and fixed some > minor bugs. Checked in. Would the E.164 country codes or international network codes be useful in any other dissectors? Also, there are other NSAP parsing routines in other dissectors: print_nsap_net_buf() in epan/osi-utils.c; dissect_atm_nsap() in packet-arp.c. Could any of them be combined (if they're parsing NSAPs with the same syntax), and are there any other dissectors that could use an NSAP parsing routine?
