Good one Martin. Maybe it would be time soon with a new release? RPC/NFS are not that uncommon protocols, and this quite serious bugfix might be one of the most important fixes for ethereal in the new release. Especially for win users.
----- Original Message ----- From: "Dr. Uwe Girlich" Sent: Monday, November 18, 2002 8:49 PM Subject: Re: [Ethereal-dev] crash on reading tracefile ( NFS ? ) > Hello list! > > > Should maybe the lines: > > --------------------------------- > > proto_tree_add_bytes_format(string_tree, > > hfindex, tvb, offset, string_length_copy, > > string_buffer_print, > > "contents: %s", string_buffer_print); > > be changed into something like: > > -------------------------------------------- > > proto_tree_add_bytes_format(string_tree, > > hfindex, tvb, offset, string_length_copy, > > string_buffer, > > "contents: %s", string_buffer_print); > That's the point. I just checked this correction in (packet-rpc.c 1.109). > We have this totally wrong code since > > >revision 1.56 > >date: 2001/04/18 20:27:42; author: guy; state: Exp; lines: +4 -2 > >Change from Ronnie Sahlberg to add ONC RPC strings to the tree as > >strings, with a field index, rather than as text, so they can be > >filtered. > Oh. stool. Why did it have to be my patch that did this?
