Guy Harris <[EMAIL PROTECTED]> schrieb am 28.10.03 19:39:30: > > On Tue, Oct 28, 2003 at 12:56:15PM +0100, Ulf Lamping wrote: > > Please could someone simply change the word (line 517): > > display_filter_construct_cb into dfilter_dialog_cb ? > > That's not a function name change. "dfilter_dialog_cb()" constructs an > "edit list of display filters" dialog, and always has; > "display_filter_construct_cb()" constructs a general display filter > dialog, and always has. > > I couldn't find anything there that changed at all recently, and I don't > get a crash when clicking on the dispaly filter toobar icon; perhaps > there's a GTK1 vs. GTK2 issue here. > > Where exactly is it crashing?
It's crashing in filter_prefs.c(line 383) in function filter_dialog_new: main_w = dlg_window_new(construct_args->title); As the construct_args parameter is NULL in this case, I get an access violation. The difference in dfilter_dialog_cb() and display_filter_construct_cb() is exactly creating this construct_args field. I had a look at the CVS, the changes seems to be done 2003.01.15 (filter_prefs.c Rev 1.43), quite a while ago ;-) BTW: This is a GTK2 problem, as I tried it without the patch with GTK1 and have no problems. Please don't ask me why this is working in GTK1 and not in GTK2, as I don't see the any difference at this point :-( Nonetheless, the functions called from menu.c () "Edit/Display Filters" and toolbar.c icon should be the same in any case. Regards, ULFL ______________________________________________________________________________ Die Besten ihrer Klasse! WEB.DE FreeMail (1,7) und WEB.DE Club (1,9) - bei der Stiftung Warentest - ein Doppelsieg! http://f.web.de/?mc=021184
