Quoting Guy Harris <[EMAIL PROTECTED]>: > We don't have a general universal Ethereal-wide approach for handling > Unicode strings, but we don't need one in order to eliminate the > duplicate code - we just need to make the "packet-smb.c" version of > "get_unicode_or_ascii_string()" take a "Unicode or not" flag rather than > a "packet_info *" as an argument, change its callers appropriately, and > make it not static. That's what I've done (and I moved it to > "packet-smb-common.c"). >
My original code did just that. I was hesitant to commit it this way though as I was concerned about hacking up packet-smb (which I don't own), by replacing the pinfo argument. Thanks for you help, Devin Heitmueller Senior Software Engineer Netilla Networks Inc
