Hi Ronnie,
Ronnie Sahlberg writes:
> Some comments though
> 1, a lot of the fields handled lacks any hf_* definitions and just use
> proto_tree_add_text
I did this based on a judgement of how I saw some people used the different
fields for filtering packets. Since there are tons of fields, I thought that
making every single possible field a filterable entity was not very useful. I
can make the change however if its generally more desirable. Alternatively, I
thought that it seems trivial to convert any field to a filterable field once
someone finds a need for it.
> 2, instead of the massive switch statements for finding the correct
> subdissector perhaps you should
> make it table driven, as for example ndmp and other dissectors are.
Agreed. I wanted to do this, but couldn't get the time before releasing
it. I'll try and send a patch to this later this week.
Dinesh
--
A hundred times every day I remind myself that my inner and outer life depend
on the labors of other men, living and dead, and that I must exert myself in
order to give in the same measure as I have received and am still receiving.
- Albert Einstein
