On Mon, Aug 26, 2002 at 04:40:16PM +0000, Flavio Poletti wrote:
> I've produced a patch

But what you attached wasn't a patch, it was new versions of
"packet-radius.c" and "packet-gtp.c".

In general, it's better to submit changes as context-diff or
unified-diff patches, rather than as new versions of files, as that way,
if the version you modified isn't the current version in the CVS tree
(for example, because you're modifying a release rather than the current
CVS code, or because other changes were checked in after you made your
changes), it's easier to merge the changes.

> which decodes the QoS in a RADIUS message (thus 
> affecting packet-radius.c) using the code available for GTP (I had to change 
> packet-gtp.c as well). 

Checked in, with some cleanups (indentation fixed; "decode_qos_umts()"
declared in "packet-gtp.h", which is included both by "packet-gtp.c" and
"packet-radius.c", rather than declaring it directly in
"packet-radius.c"; tree item for non-EAP items initially created with
type and length, and value added by "proto_item_append_text()" after
"rd_value_to_str()" returns it).

Reply via email to