On Wed, Feb 11, 2004 at 09:05:33AM +0100, Ulf Lamping wrote:
> I had to add:
> 
>       alert_box.obj   \
> 
> to the definition of ethereal_OBJECTS in Makefile.nmake, to get it linking.
> I cannot check this in, as I have no CVS access at the moment.

I've checked that in.

> There seems to be more things in need of a cleanup for the "Makefile.common",

Yes, I was assuming, incorrectly, that the top-level Makefile.nmake was
getting all the source file names from Makefile.common.

> Nonetheless, in file.c and alert_box.c are some similar functions now, like:
> 
> cf_open_failure_alert_box
> cf_write_failure_alert_box
> cf_close_failure_alert_box
> 
> Which might be merged in some way with the new alert_box stuff?

Merged in what way?  I don't know whether putting stuff to handle
Wiretap error values into the new alert_box stuff would be the right
thing to do - it's probably safe, although it *could* cause confusing
error messages to be produced if, somehow, "errno" gets set to a
negative number (as it'd be interpreted as a Wiretap error number).

The ones in file.c call the alert_box.c routines for UN*X-style errno
values; they just add support for Wiretap errors.

_______________________________________________
Ethereal-dev mailing list
[EMAIL PROTECTED]
http://www.ethereal.com/mailman/listinfo/ethereal-dev

Reply via email to