Author: ericwa
Date: Thu Mar 20 00:46:58 2014
New Revision: 10589
URL: http://svn.gna.org/viewcvs/etoile?rev=10589&view=rev
Log:
Add reminders to revert COObject to pointer hash/equality. See failing test
-[TestObject testHashStabilityAcrossSetCurrentBranch] and Jan 25th email
Modified:
trunk/Etoile/Frameworks/CoreObject/Core/COObject.m
trunk/Etoile/Frameworks/CoreObject/TODO.md
Modified: trunk/Etoile/Frameworks/CoreObject/Core/COObject.m
URL:
http://svn.gna.org/viewcvs/etoile/trunk/Etoile/Frameworks/CoreObject/Core/COObject.m?rev=10589&r1=10588&r2=10589&view=diff
==============================================================================
--- trunk/Etoile/Frameworks/CoreObject/Core/COObject.m (original)
+++ trunk/Etoile/Frameworks/CoreObject/Core/COObject.m Thu Mar 20 00:46:58 2014
@@ -1338,11 +1338,13 @@
#pragma mark - Hash and Equality
+// FIXME: Remove, to revert to pointer hash/equality. See failing test
-[TestObject testHashStabilityAcrossSetCurrentBranch] and Jan 25th email
- (NSUInteger)hash
{
return [_UUID hash] ^ [[_objectGraphContext branchUUID] hash] ^
[_objectGraphContext isTrackingSpecificBranch] ^ 0x39ab6f39b15233de;
}
+// FIXME: Remove, to revert to pointer hash/equality. See failing test
-[TestObject testHashStabilityAcrossSetCurrentBranch] and Jan 25th email
- (BOOL)isEqual: (id)anObject
{
if (anObject == self)
Modified: trunk/Etoile/Frameworks/CoreObject/TODO.md
URL:
http://svn.gna.org/viewcvs/etoile/trunk/Etoile/Frameworks/CoreObject/TODO.md?rev=10589&r1=10588&r2=10589&view=diff
==============================================================================
--- trunk/Etoile/Frameworks/CoreObject/TODO.md (original)
+++ trunk/Etoile/Frameworks/CoreObject/TODO.md Thu Mar 20 00:46:58 2014
@@ -324,6 +324,7 @@
- Add some collection-oriented KVO update tests to TestObjectUpdate
+ - Remove COObject -hash, -isEqual: so we use NSObject's version (pointer
comparison). See failing test -[TestObject
testHashStabilityAcrossSetCurrentBranch] and Jan 25th email
- COObjectGraphContext
_______________________________________________
Etoile-cvs mailing list
[email protected]
https://mail.gna.org/listinfo/etoile-cvs
