At 23:23 Uhr +0100 14.02.2005, Quentin Mathé wrote:
I would like separate class(es) similar to what it is now.
Okay, then a separate provider class it will be :-)
We may also want to use that other call
GNUstep has for getting standard images instead
of imageNamed:.
Which other calls ?
I've seen some GNUstep code use some new NSImage
call for getting standard images from the system
... +standardImageNamed: or something named like
that. I think that one would be more correct, but
the GNUstep sources I have here don't contain it
yet.
In IKIconIdentifier.h :
extern IKIconIdentifier IKIconTrashFolder;
<-- we should have IKIconRecyclerFolder for
GNUstep too
extern IKIconIdentifier IKIconTrashFolderFull; <-- idem
// ...
You mean we should rename it to "Recycler"
instead of trash? Remember, these identifiers are
supposed to be names that can be used
cross-platform to get the right standard icons,
so we can't have a recycler *and* a trash.
extern IKIconIdentifier IKIconSymLinkBadge;
<-- I would prefer IKIconLinkBadge because they
are the only sort of links the user should be
able to manipulate in Finder/Workspace, except
Alias-like link but they should use this badge
too in my opinion
Okay, I'll rename it to Link.
+(id) iconForFile: (NSString*)path;
-initWithURL: would be welcome too.
Right.
// Icon needs to be scaled/moved before compositing?
if( pos.origin.x != 0 || pos.origin.y != 0
|| pos.size.width != mySize.width || pos.size.height != mySize.height
if( (pos & IKBadgePositionFlagTop) == IKBadgePositionFlagTop )
// Move to top?
box.origin.y += fullSize.height -box.size.height;
if( (pos & IKBadgePositionFlagRight) ==
IKBadgePositionFlagRight ) // Move to right?
box.origin.x += fullSize.width -box.size.width;
What is the reason of the question marks here ?
These are simply comments that describe what the
"if" does. The question marks don't mean that I'm
unsure what it does. It's simply how I define
comments for "if"s.
otherwise everything looks ok for me from an
architectural perspective. We need to solve the
compositor problem now and to do the merge with
the version in Étoilé cvs, and on my side to
refactor IKProvider related classes.
Could you elaborate what you mean by "the compositor problem"?
Would be nice too to merge our various demo
examples in one example compiling on both
GNUstep and Mac OS X, and which demonstrates
compositing operations (with optional property
list), badges and providers mechanism (this last
part of the demo would be invisible under Mac OS
X probably ).
Yes, that could be handy. However, I thought my
example pretty much did everything you can do
with IconKit... Adding a better GUI is a good
idea, are there any other features we're still
missing (besides the part of asking the provider
for the correct icon images)?
--
Cheers,
M. Uli Kusterer
------------------------------------------------------------
"The Witnesses of TeachText are everywhere..."
http://www.zathras.de
